feat(storage): another Bucket CRUD field #12842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
|
/FYI @cojenco |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12842 +/- ##
==========================================
- Coverage 93.55% 93.55% -0.01%
==========================================
Files 2074 2074
Lines 180452 180513 +61
==========================================
+ Hits 168815 168871 +56
- Misses 11637 11642 +5
☔ View full report in Codecov by Sentry. |
This time, the `Bucket.auto_class()` gains `terminal_storage_class`, and `OUTPUT_ONLY` `terminate_storage_class_update` fields. Only interesting for completeness sake.
coryan
force-pushed
the
feat-storage-support-terminal-storage-class
branch
from
3aba1bd
to
3063975
Compare
devbww
approved these changes
Oct 9, 2023
| auto const object_name = | ||
| examples::MakeRandomObjectName(generator, "object-") + ".txt"; | ||
| auto client = gcs::Client(); | ||
|
|
||
| std::cout << "\nCreating buckets to run the example:" | ||
| << "\nEnabled Autoclass: " << bucket_name_enabled | ||
| << "\nDisabled Autoclass: " << bucket_name_disabled << std::endl; | ||
| << "\nDisabled Autoclass: " << bucket_name_disabled | ||
| << "\nArchive Autclass: " << bucket_name_archive << std::endl; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time, the
Bucket.auto_class()gainsterminal_storage_class, andOUTPUT_ONLYterminate_storage_class_updatefields. Only interesting for completeness sake.Fixes #12658
This change is