fix(otel): support abseil <= 20210324 #12993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12993 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 2068 2069 +1
Lines 180929 180942 +13
=======================================
+ Hits 169344 169359 +15
+ Misses 11585 11583 -2
☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Oct 27, 2023
| span_context.span_id().ToLowerBase16({span_id.data(), span_id.size() - 1}); | ||
| span_id[2 * SpanId::kSize] = '\0'; | ||
| char* end = nullptr; | ||
| std::uint64_t span_id_dec = std::strtoull(span_id.data(), &end, 16); |
There was a problem hiding this comment.
Why not handle errors, just like the implementation with absl::SimpleHexAtoi() did?
Suggested change
| std::uint64_t span_id_dec = std::strtoull(span_id.data(), &end, 16); | |
| auto const span_id_dec = std::strtoull(span_id.data(), &end, 16); | |
| if (end != span_id.data() + span_id.size()) return; |
dbolduc
force-pushed
the
fix-otel-support-older-abseil
branch
from
1bf8901
to
535ee80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #12991
SimpleHexAtoi()was not added until later.Updates to
cmake-oldest-deps.shrevealed this.... but I need to do a few things to update that script. So there is no verification in our CI at this commit.This change is