fix(common): missed using CARootsFilePathOption
#12997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of credentials failed to use the `CARootsFilePathOption` as they should. Use the storage integration test because it covers both gRPC and REST.
coryan
force-pushed
the
fix-common-use-CARootsFilePathOption
branch
from
483fd8d
to
7c9646e
Compare
devbww
approved these changes
Oct 30, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12997 +/- ##
==========================================
- Coverage 93.59% 93.59% -0.01%
==========================================
Files 2068 2068
Lines 180931 180934 +3
==========================================
- Hits 169350 169347 -3
- Misses 11581 11587 +6
☔ View full report in Codecov by Sentry. |
dbolduc
reviewed
Oct 30, 2023
google/cloud/credentials.h
Outdated
| * You should set this option both in the credentials and the client options. | ||
| * For example: | ||
| * @code | ||
| * using gc = ::google::cloud; |
google/cloud/credentials.h
Outdated
| * does not use the default root of trust. Though it might be possible to | ||
| * set the `GRPC_DEFAULT_SSL_ROOTS_FILE_PATH` environment variable instead. | ||
| * | ||
| * You should set this option both in the credentials and the client options. |
There was a problem hiding this comment.
s/and the client options/and in the connection options/
They would not apply if passed to the client only, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of credentials failed to use the
CARootsFilePathOptionas they should.Use the storage integration test because it covers both gRPC and REST.
This change is