feat(common): add GrpcCompressionAlgorithmOption #13108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a common option to set the gRPC compression algorithm, which can be used at both the client and individual-operation levels. (Previously, users could only affect client-to-server compression at the connection level, using `GrpcChannelArgumentsNativeOption`.) - It will take precedence over any compression algorithm set by the `internal::GrpcSetupOption` function. - The `pubsub::CompressionAlgorithmOption` takes precedence over any other settings during `AsyncPublish()` calls when the request-size threshold is met. Exercise the new option in the Spanner client in two ways: - A new `ConnectionImpl` test to check that the compression algorithm from the prevailing options is reflected in the `grpc::ClientContext` passed to the stub. - Setting the compression algorithm used during the client integration tests, but overriding it on a few operations. (We can't directly observe the effect, but we've done our part.)
devbww
force-pushed
the
spanner-compression
branch
from
170391d
to
d9ef78f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13108 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 2135 2135
Lines 185608 185637 +29
=======================================
+ Hits 172601 172632 +31
+ Misses 13007 13005 -2
☔ View full report in Codecov by Sentry. |
dbolduc
approved these changes
Nov 11, 2023
coryan
reviewed
Nov 11, 2023
| @@ -135,6 +139,7 @@ TEST(DefaultBatchSinkTest, BasicWithCompression) { | |||
| std::move(mock), background.cq(), | |||
| DefaultPublisherOptions( | |||
| pubsub_testing::MakeTestOptions() | |||
| .set<GrpcCompressionAlgorithmOption>(GRPC_COMPRESS_NONE) | |||
There was a problem hiding this comment.
@alevenberg maybe we should consider using pubsub::CompressionAlgorithmOption = google::cloud::GrpcCompressionAlgorithmOption;
There was a problem hiding this comment.
That might be problematic, given that pubsub::CompressionAlgorithmOption is given a default value (of GRPC_COMPRESS_DEFLATE).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a common option to set the gRPC compression algorithm, which can be used at both the client and individual-operation levels. (Previously, users could only affect client-to-server compression at the connection level, using
GrpcChannelArgumentsNativeOption.)It will take precedence over any compression algorithm set by the
internal::GrpcSetupOptionfunction.The
pubsub::CompressionAlgorithmOptiontakes precedence over any other settings duringAsyncPublish()calls when the request-size threshold is met.Exercise the new option in the Spanner client in two ways:
ConnectionImpltest to check that the compression algorithm from the prevailing options is reflected in thegrpc::ClientContextpassed to the stub.This change is