Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): read-write streaming RPCs metadata #13228

Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat(common): read-write streaming RPCs metadata #13228

merged 2 commits into from
Dec 5, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 5, 2023 •
edited
Loading

This change is Reviewable

@coryan coryan marked this pull request as ready for review December 5, 2023 16:34
@coryan coryan requested a review from a team as a code owner December 5, 2023 16:34
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c773574) 92.99% compared to head (39e1f86) 92.99%.

Files Patch % Lines
...ogle/cloud/internal/async_read_write_stream_impl.h 33.33% 2 Missing ⚠️
google/cloud/async_streaming_read_write_rpc.h 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13228   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files        2135     2135           
  Lines      186327   186389   +62     
=======================================
+ Hits       173274   173335   +61     
- Misses      13053    13054    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devbww
devbww approved these changes Dec 5, 2023
View reviewed changes
google/cloud/internal/async_read_write_stream_impl.h Outdated
@@ -144,6 +145,10 @@ class AsyncStreamingReadWriteRpcImpl
return op->p.get_future();
}

RpcMetadata GetRequestMetadata() const override {
return google::cloud::internal::GetRequestMetadataFromContext(*context_);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. Is the full qualification to the current scope necessary/desirable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Fixed.

@coryan coryan enabled auto-merge (squash) December 5, 2023 19:45
@coryan coryan merged commit 7d44ca4 into googleapis:main Dec 5, 2023
59 checks passed
@coryan coryan deleted the feat-rpc-metadata-for-read-write-streaming-rpcs branch December 5, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devbww