Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): use FQDN #13305

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix(bigtable): use FQDN #13305

merged 1 commit into from
Dec 13, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Dec 13, 2023

Follow up to #13254 for bigtable.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4b0970) 93.05% compared to head (4a9b3eb) 93.05%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13305      +/-   ##
==========================================
- Coverage   93.05%   93.05%   -0.01%     
==========================================
  Files        2137     2137              
  Lines      186491   186491              
==========================================
- Hits       173548   173541       -7     
- Misses      12943    12950       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review December 13, 2023 23:12
@dbolduc dbolduc requested a review from a team as a code owner December 13, 2023 23:12
@dbolduc dbolduc merged commit c6015b7 into googleapis:main Dec 13, 2023
59 checks passed
@dbolduc dbolduc deleted the bigtable-fqdn branch December 13, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants