Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(securitycenter): re-enable on windows #14282

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented May 23, 2024

I am told that the macros are resolved in protobuf v27, which we now test with.

While we're here, refactor the Bazel file in accordance with #14171

YOLO


This change is Reviewable

@dbolduc dbolduc added the gha:full-build Trigger a full build in GHA label May 23, 2024
@product-auto-label product-auto-label bot added the api: securitycenter Issues related to the Security Command Center API. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.50%. Comparing base (47792d2) to head (91d2e63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14282      +/-   ##
==========================================
+ Coverage   92.94%   93.50%   +0.55%     
==========================================
  Files        2048     2135      +87     
  Lines      180801   191573   +10772     
==========================================
+ Hits       168038   179121   +11083     
+ Misses      12763    12452     -311     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review May 23, 2024 23:06
@dbolduc dbolduc requested a review from a team as a code owner May 23, 2024 23:06
@dbolduc dbolduc merged commit 45ed21b into googleapis:main May 23, 2024
71 checks passed
@dbolduc dbolduc deleted the gapic-bazel-refactor-securitycenter branch May 23, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: securitycenter Issues related to the Security Command Center API. gha:full-build Trigger a full build in GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants