Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples(storagecontrol): add storagecontrol managed folder samples #14356

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

ddelgrosso1
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 commented Jun 21, 2024

Fixes #14305


This change is Reviewable

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners June 21, 2024 19:16
Copy link

snippet-bot bot commented Jun 21, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 21, 2024
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great, thanks.

I am sad that we are spending time on this type of example. We should be thinking about either (1) using snippetgen, or (2) write a product-neutral, and resource-neutral examples. That is, we should have an example that is the prototypical "CreateFoo()", and another for "DeleteFoo()" and another for "Using LROs".

@ddelgrosso1
Copy link
Contributor Author

@coryan I agree. These are almost an exact copy of the folder samples I did last week with a few names changed around.

I was having some side conversation recently because some languages (i.e. node) already have generated samples for folders / managed folders but we are still hand re-writing them. It seems like we could spend the same time improving the toolset that is generating samples so that they are auto generated to our standard and then bring the tools / samples across all languages.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (3739c56) to head (d62188b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14356      +/-   ##
==========================================
+ Coverage   93.19%   93.68%   +0.48%     
==========================================
  Files        2191     2280      +89     
  Lines      192367   203329   +10962     
==========================================
+ Hits       179282   190480   +11198     
+ Misses      13085    12849     -236     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddelgrosso1 ddelgrosso1 merged commit cac2123 into main Jun 21, 2024
66 checks passed
@ddelgrosso1 ddelgrosso1 deleted the manage-folder-samples branch June 21, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: Samples for Managed Folders
2 participants