feat(spanner): support instance edition #14678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolduc
approved these changes
Sep 4, 2024
| @@ -117,13 +117,59 @@ class CreateInstanceRequestBuilder { | |||
| return std::move(*this); | |||
| } | |||
|
|
|||
| enum class Edition { kStandard = 0, kEnterprise, kEnterprisePlus }; | |||
There was a problem hiding this comment.
documentation?
Also, nit: drop the = 0 ?
scotthart
commented
Sep 4, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @dbolduc)
google/cloud/spanner/create_instance_request_builder.h line 120 at r1 (raw file):
Previously, dbolduc (Darren Bolduc) wrote…
documentation?
Also, nit: drop the
= 0?
Done.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14678 +/- ##
==========================================
- Coverage 93.62% 93.62% -0.01%
==========================================
Files 2320 2320
Lines 207152 207188 +36
==========================================
+ Hits 193947 193978 +31
- Misses 13205 13210 +5 ☔ View full report in Codecov by Sentry. |
scotthart
force-pushed
the
spanner_instance_builder_edition
branch
from
d31f355
to
15fb48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is