Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid ApiKeyOption in sample #14760

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 3, 2024

Part of the work for #14759

Avoid using ApiKeyOption which we will remove shortly. We do not want to scrap the sample. Luckily we can achieve the same effect as ApiKeyOption using other options in our library.

Also, we should break out of the backoff loop when an attempt to authenticate is successful.


This change is Reviewable

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (a695357) to head (736c2da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14760      +/-   ##
==========================================
- Coverage   93.39%   93.39%   -0.01%     
==========================================
  Files        2316     2316              
  Lines      207867   207870       +3     
==========================================
- Hits       194139   194136       -3     
- Misses      13728    13734       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review October 3, 2024 16:57
@dbolduc dbolduc requested a review from a team as a code owner October 3, 2024 16:57
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 1289fa6 into googleapis:main Oct 3, 2024
73 of 74 checks passed
@dbolduc dbolduc deleted the refactor-avoid-api-key-option branch October 3, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants