Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(mixin): remove duplicated operations stub #14838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented Nov 11, 2024

fix #14746


This change is Reviewable

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 91.57895% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.07%. Comparing base (03796d8) to head (eb1c11c).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
generator/internal/stub_factory_generator.cc 0.00% 3 Missing ⚠️
generator/internal/stub_generator.cc 0.00% 3 Missing ⚠️
...ration_tests/golden/v1/internal/request_id_stub.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14838   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files        2319     2319           
  Lines      209023   209035   +12     
=======================================
+ Hits       194538   194552   +14     
+ Misses      14485    14483    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuiy0006 cuiy0006 marked this pull request as ready for review November 11, 2024 19:43
@cuiy0006 cuiy0006 requested review from a team as code owners November 11, 2024 19:43
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 533 of 533 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cuiy0006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up deduplicated operation stubs in stub_generator
2 participants