Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(managedkafka): change old title to new title #14846

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

noahdietz
Copy link

@noahdietz noahdietz commented Nov 15, 2024

Changes all instances of the "old" product title to the "new" one. Internal bug http://b/379316147

This change is Reviewable

@noahdietz noahdietz requested a review from a team as a code owner November 15, 2024 21:54
@product-auto-label product-auto-label bot added the api: managedkafka Issues related to the Google Cloud Managed Service for Apache Kafka API. label Nov 15, 2024
@dbolduc
Copy link
Member

dbolduc commented Nov 15, 2024

/gcbrun

@dbolduc
Copy link
Member

dbolduc commented Nov 15, 2024

Thanks! To pass the formatting build, can you run the following and commit the changes:

ci/cloudbuild/build.sh -t checkers-pr

And if you are wondering why this naming stuff is maintained by hand, there is some discussion in #10237

@noahdietz
Copy link
Author

Thanks! To pass the formatting build, can you run the following and commit the changes:

ci/cloudbuild/build.sh -t checkers-pr

Done!

@dbolduc
Copy link
Member

dbolduc commented Nov 15, 2024

/gcbrun

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (04f67a7) to head (c285db2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14846      +/-   ##
==========================================
- Coverage   93.07%   93.06%   -0.01%     
==========================================
  Files        2319     2319              
  Lines      209097   209097              
==========================================
- Hits       194620   194604      -16     
- Misses      14477    14493      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: managedkafka Issues related to the Google Cloud Managed Service for Apache Kafka API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants