-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): exactly-once delivery #9436
feat(pubsub): exactly-once delivery #9436
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9436 +/- ##
========================================
Coverage 94.62% 94.62%
========================================
Files 1486 1487 +1
Lines 136452 136623 +171
========================================
+ Hits 129116 129282 +166
- Misses 7336 7341 +5
Continue to review full report at Codecov.
|
google/cloud/pubsub/integration_tests/subscriber_integration_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/pubsub/integration_tests/subscriber_integration_test.cc
Outdated
Show resolved
Hide resolved
Implement the API to subscribe with exactly-once delivery, make `ExactlyOnceAckHandler` public, add the samples, and also add an integration test.
643fea0
to
156cc88
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
google/cloud/pubsub/integration_tests/subscriber_integration_test.cc
Outdated
Show resolved
Hide resolved
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Implement the API to subscribe with exactly-once delivery, make
ExactlyOnceAckHandler
public, add the samples, and also add anintegration test.
Part of the work for #9327
This change is