Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): exactly-once delivery #9436

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 6, 2022

Implement the API to subscribe with exactly-once delivery, make
ExactlyOnceAckHandler public, add the samples, and also add an
integration test.

Part of the work for #9327


This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 6, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jul 6, 2022

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 643fea0b9247a67c6e5c09a8332dfd8699e4ea19

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #9436 (a6f80dc) into main (2e1a647) will increase coverage by 0.00%.
The diff coverage is 98.96%.

@@           Coverage Diff            @@
##             main    #9436    +/-   ##
========================================
  Coverage   94.62%   94.62%            
========================================
  Files        1486     1487     +1     
  Lines      136452   136623   +171     
========================================
+ Hits       129116   129282   +166     
- Misses       7336     7341     +5     
Impacted Files Coverage Δ
google/cloud/pubsub/exactly_once_ack_handler.cc 100.00% <ø> (ø)
google/cloud/pubsub/exactly_once_ack_handler.h 70.58% <ø> (ø)
...ogle/cloud/pubsub/exactly_once_ack_handler_test.cc 100.00% <ø> (ø)
...ubsub/internal/subscription_concurrency_control.cc 94.02% <ø> (ø)
...pubsub/internal/subscription_concurrency_control.h 100.00% <ø> (ø)
.../internal/subscription_concurrency_control_test.cc 100.00% <ø> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <ø> (ø)
google/cloud/pubsub/subscriber_connection.cc 77.46% <84.61%> (-1.33%) ⬇️
...b/integration_tests/subscriber_integration_test.cc 98.57% <100.00%> (+0.24%) ⬆️
...ogle/cloud/pubsub/internal/subscription_session.cc 96.12% <100.00%> (-0.03%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1a647...a6f80dc. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 6, 2022 21:10
@coryan coryan requested a review from a team as a code owner July 6, 2022 21:10
google/cloud/pubsub/subscriber.h Outdated Show resolved Hide resolved
google/cloud/pubsub/subscriber.h Outdated Show resolved Hide resolved
google/cloud/pubsub/subscriber.h Show resolved Hide resolved
Implement the API to subscribe with exactly-once delivery, make
`ExactlyOnceAckHandler` public, add the samples, and also add an
integration test.
@coryan coryan force-pushed the feat-pubsub-exactly-once-delivery-pr1 branch from 643fea0 to 156cc88 Compare July 7, 2022 13:52
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 156cc88027caadadfec66cfb2e73b6b874c0a8ab

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google/cloud/pubsub/subscriber_connection.h Outdated Show resolved Hide resolved
google/cloud/pubsub/subscriber.h Show resolved Hide resolved
@coryan coryan enabled auto-merge (squash) July 7, 2022 14:41
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a6f80dcd6de39b9e11016fb26d87b4cb90ec7022

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit a12ed2c into googleapis:main Jul 7, 2022
@coryan coryan deleted the feat-pubsub-exactly-once-delivery-pr1 branch July 7, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants