Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): equality for copyable classes #9648

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 7, 2022

Part of the work for #2310

The classes are:

  • spanner::CreateInstanceRequestBuilder
  • spanner::UpdateInstanceRequestBuilder

This change is Reviewable

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 7, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 76c6d91ff52969ef00b310c97f11ec7768685f0e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #9648 (76c6d91) into main (a508bb6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9648      +/-   ##
==========================================
- Coverage   94.35%   94.35%   -0.01%     
==========================================
  Files        1493     1493              
  Lines      138786   138813      +27     
==========================================
+ Hits       130956   130980      +24     
- Misses       7830     7833       +3     
Impacted Files Coverage Δ
...le/cloud/spanner/create_instance_request_builder.h 100.00% <100.00%> (ø)
...ud/spanner/create_instance_request_builder_test.cc 100.00% <100.00%> (ø)
...le/cloud/spanner/update_instance_request_builder.h 100.00% <100.00%> (ø)
...ud/spanner/update_instance_request_builder_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.75% <0.00%> (-0.57%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 8, 2022 00:06
@dbolduc dbolduc requested a review from a team as a code owner August 8, 2022 00:06
@dbolduc dbolduc merged commit a6d859e into googleapis:main Aug 8, 2022
@dbolduc dbolduc deleted the spanner-equality-for-copyable-classes branch August 8, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants