feat(dataproc): mark the dataproc services as location dependent #9722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There will now be an additional `Make<Service>Connection()` overload that takes a `location` parameter, which is used to build the default `EndpointOption` value (see googleapis#9625). Update the quickstart to use the new `MakeClusterControllerConnection()` overload. Fixes googleapis#8239.
product-auto-label
bot
added
the
api: dataproc
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9722 +/- ##
==========================================
- Coverage 93.89% 93.88% -0.01%
==========================================
Files 1495 1495
Lines 139580 139580
==========================================
- Hits 131056 131044 -12
- Misses 8524 8536 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
coryan
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There will now be an additional
Make<Service>Connection()overloadthat takes a
locationparameter, which is used to build the defaultEndpointOptionvalue (see #9625).Update the quickstart to use the new
MakeClusterControllerConnection()overload.
Fixes #8239.
This change is