Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): release *StallMinimumThroughputOption #9813

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 9, 2022

These options have proven useful. Time to move them out of storage_experimental.


This change is Reviewable

These options have proven useful. Time to move them out of
`storage_experimental`.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 9, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 38055d8f5391c8ed0a3f53284a4bd2bbefea9a21

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a feat(storage): release *StallMinimumThroughputOption

@coryan coryan changed the title cleanup(storage): de-experiment *StallMinimumThroughputOption feat(storage): release *StallMinimumThroughputOption Sep 9, 2022
@coryan coryan marked this pull request as ready for review September 9, 2022 19:45
@coryan coryan requested a review from a team as a code owner September 9, 2022 19:45
@coryan coryan enabled auto-merge (squash) September 9, 2022 19:46
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #9813 (38055d8) into main (eb5ad36) will decrease coverage by 0.00%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main    #9813      +/-   ##
==========================================
- Coverage   94.24%   94.24%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      139805   139801       -4     
==========================================
- Hits       131756   131749       -7     
- Misses       8049     8052       +3     
Impacted Files Coverage Δ
google/cloud/storage/benchmarks/benchmark_utils.cc 26.21% <0.00%> (ø)
...enchmarks/aggregate_download_throughput_options.cc 85.32% <100.00%> (ø)
...arks/aggregate_download_throughput_options_test.cc 100.00% <100.00%> (ø)
.../benchmarks/aggregate_upload_throughput_options.cc 81.66% <100.00%> (ø)
...hmarks/aggregate_upload_throughput_options_test.cc 100.00% <100.00%> (ø)
...gle/cloud/storage/benchmarks/throughput_options.cc 84.91% <100.00%> (ø)
...loud/storage/benchmarks/throughput_options_test.cc 100.00% <100.00%> (ø)
google/cloud/storage/client_options.cc 88.46% <100.00%> (ø)
google/cloud/storage/client_options_test.cc 100.00% <100.00%> (ø)
...gle/cloud/storage/internal/curl_request_builder.cc 91.91% <100.00%> (-0.17%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@coryan coryan merged commit a0bda06 into googleapis:main Sep 9, 2022
@coryan coryan deleted the cleanup-storage-de-experiment-StallMinimumThroughputOption branch September 9, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants