feat(storage): easier mocks for *AccessControl
#9910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add modifiers for all the attributes in `ObjectAccessControl` and `BucketAccessControl`. That makes it easier to mock the class. I deprecated `internal::AccessControlCommon` as this class is no longer used.
product-auto-label
bot
added
the
api: storage
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.20% // Head: 94.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #9910 +/- ##
========================================
Coverage 94.20% 94.20%
========================================
Files 1495 1495
Lines 140166 140285 +119
========================================
+ Hits 132043 132157 +114
- Misses 8123 8128 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add modifiers for all the attributes in
ObjectAccessControlandBucketAccessControl. That makes it easier to mock the class.I deprecated
internal::AccessControlCommonas this class is no longer used.Part of the work for #8929
This change is