Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): easier mocks for HmacKeyMetadata #9949

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 29, 2022

Add modifiers to make mocking easier. Remove unneeded friend declarations after this change.

Part of the work for #8929


This change is Reviewable

Add modifiers to make mocking easier. Remove unneeded `friend`
declarations after this change.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 29, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8b1dd6c99d479dab6ed86fd4243b86413fe32654

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 94.20% // Head: 94.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8b1dd6c) compared to base (e8fb790).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9949   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files        1497     1497           
  Lines      140407   140428   +21     
=======================================
+ Hits       132273   132297   +24     
+ Misses       8134     8131    -3     
Impacted Files Coverage Δ
google/cloud/storage/hmac_key_metadata.h 100.00% <100.00%> (ø)
.../storage/internal/grpc_hmac_key_metadata_parser.cc 92.30% <100.00%> (ø)
...cloud/storage/internal/hmac_key_metadata_parser.cc 100.00% <100.00%> (ø)
...le/cloud/storage/internal/curl_download_request.cc 88.29% <0.00%> (-1.01%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
google/cloud/storage/parallel_upload.cc 98.26% <0.00%> (-0.35%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (+0.16%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️
...e/cloud/spanner/testing/cleanup_stale_instances.cc 75.40% <0.00%> (+6.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review September 29, 2022 13:32
@coryan coryan requested a review from a team as a code owner September 29, 2022 13:32
@coryan coryan merged commit 5291bb8 into googleapis:main Sep 29, 2022
@coryan coryan deleted the feat-storage-easier-mocks-for-HmacKeyMetadata branch September 29, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants