Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: TestIntegration_CancelWrite failed #3688

Closed
flaky-bot bot opened this issue Feb 9, 2021 · 1 comment · Fixed by #3691
Closed

storage: TestIntegration_CancelWrite failed #3688

flaky-bot bot opened this issue Feb 9, 2021 · 1 comment · Fixed by #3691
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Feb 9, 2021

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.

commit: 8f4e130
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:2567: got Post "https://storage.googleapis.com/upload/storage/v1/b/go-integration-test-20210209-67407505045772-0001/o?alt=json&name=cancel-write&prettyPrint=false&projection=full&uploadType=resumable": context canceled, wanted context.Canceled
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 9, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 9, 2021
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Feb 9, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Feb 9, 2021

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (8f4e130), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

tritone added a commit to tritone/google-cloud-go that referenced this issue Feb 9, 2021
@tritone
test(storage): unflake TestIntegration_CancelWrite
6ae3acd 
Rarely a wrapped context.Cancel error can be returned from the
writer, so the current check will fail. We have to resort to string
matching for now, but for Go >= 1.13 errors.Is should work.

Fixes googleapis#3688
@tritone tritone mentioned this issue Feb 9, 2021
Merged
tritone added a commit that referenced this issue Feb 9, 2021
@tritone
test(storage): unflake TestIntegration_CancelWrite (#3691)
00a78aa 
Rarely a wrapped context.Cancel error can be returned from the
writer, so the current check will fail. We have to resort to string
matching for now, but for Go >= 1.13 errors.Is should work.

Fixes #3688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(storage): unflake TestIntegration_CancelWrite tritone/google-cloud-go
1 participant
@tritone