Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage/dataflux): add range_splitter #10748 #10899

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

akansha1812
Copy link
Contributor

@akansha1812 akansha1812 commented Sep 20, 2024

feat: add dataflux range_splitter which will be consumed by worksteal algorithm
Dataflux fast-listing will be used to quickly list objects in a bucket in parallel leveraging worksteal algorithm. Worksteal algorithm uses range splitter to split alphabets for parallel listing.

newRangeSplitter is to initialize range splitter and splitRange is used to divide start and end string into a given number of equally spaced splits.

Fixes #10731

@akansha1812 akansha1812 requested review from a team as code owners September 20, 2024 20:24
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 20, 2024
Copy link

conventional-commit-lint-gcf bot commented Sep 20, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@akansha1812 akansha1812 changed the title feat(storage/dataflux): add dataflux range_splitter #10748 feat(storage/dataflux): add range_splitter #10748 Sep 20, 2024
Copy link
Contributor

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. Thanks for the PR!

storage/dataflux/fast_list.go Outdated Show resolved Hide resolved
storage/dataflux/range_splitter_test.go Outdated Show resolved Hide resolved
storage/dataflux/range_splitter.go Outdated Show resolved Hide resolved
storage/dataflux/range_splitter.go Show resolved Hide resolved
storage/dataflux/range_splitter.go Outdated Show resolved Hide resolved
storage/dataflux/range_splitter.go Outdated Show resolved Hide resolved
storage/dataflux/range_splitter.go Show resolved Hide resolved
storage/dataflux/range_splitter.go Outdated Show resolved Hide resolved
storage/dataflux/range_splitter.go Outdated Show resolved Hide resolved
storage/dataflux/range_splitter.go Show resolved Hide resolved
@BrennaEpp BrennaEpp merged commit d49da26 into googleapis:main Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: implement dataflux fast listing
2 participants