chore(tests): fix kubectl installation in environment test script #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
https://github.com/googleapis/testing-infra-docker/tree/master/go are all of the version that we use in the client libraries. |
codyoss
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4561
I had attempted to add manual kubectl installation to the environment test script, but there were a couple issues, and the test was still failing. I fixed the issues, and confirmed it works this time by finding and and running the changes inside the
gcr.io/cloud-devrel-kokoro-resources/go111test containerNote that this impacts the environment.sh test script only currently used by the logging library.
@codyoss, you mentioned we should consider making these changes in the base image. Do you know where I could submit that change?