chore(storage): add retry metric headers #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
tritone
changed the title
noahdietz
reviewed
May 10, 2022
|
Do we have these new headers documented internally? Are they already standardized? If not I am not sure we should add things to this header without more convo |
noahdietz
reviewed
May 16, 2022
Yes, this has already been standardized and approved internally. Will send you a doc. |
noahdietz
approved these changes
May 16, 2022
unforced
approved these changes
May 17, 2022
ddelgrosso1
reviewed
May 17, 2022
4 tasks
ddelgrosso1
approved these changes
May 18, 2022
tritone
added a commit
to tritone/google-api-go-client
that referenced
this pull request
Jun 10, 2022
Adds invocation ID and attempt count to x-goog-api-client header for simple and resumable uploads. Note that this will also add this information to chunk upload requests for individual chunks for BQ and other APIs that do uploads using gensupport as well. Hopefully this isn't an issue. Similar to googleapis/google-cloud-go#6013
tritone
added a commit
to googleapis/google-api-go-client
that referenced
this pull request
Jun 21, 2022
Adds invocation ID and attempt count to x-goog-api-client header for simple and resumable uploads. Note that this will also add this information to chunk upload requests for individual chunks for BQ and other APIs that do uploads using gensupport as well. Hopefully this isn't an issue. Similar to googleapis/google-cloud-go#6013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds retry metrics to X-Goog-Api-Client header.
Format will be:
X-Goog-Api-Client: gccl-invocation-id/7a808dc9-2865-4777-beee-cf8259ef7fe0 gccl-attempt-count/1 gl-go/1.18.0 gccl/1.22.0Does not include uploads & downloads, or experimental gRPC methods. Support for these will be added later.