-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storage): add retry metric headers #6013
Conversation
Do we have these new headers documented internally? Are they already standardized? If not I am not sure we should add things to this header without more convo |
Yes, this has already been standardized and approved internally. Will send you a doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good to me, although I'd wait for Denis' eyes on it as he probably knows golang better than I do.
Adds invocation ID and attempt count to x-goog-api-client header for simple and resumable uploads. Note that this will also add this information to chunk upload requests for individual chunks for BQ and other APIs that do uploads using gensupport as well. Hopefully this isn't an issue. Similar to googleapis/google-cloud-go#6013
Adds invocation ID and attempt count to x-goog-api-client header for simple and resumable uploads. Note that this will also add this information to chunk upload requests for individual chunks for BQ and other APIs that do uploads using gensupport as well. Hopefully this isn't an issue. Similar to googleapis/google-cloud-go#6013
Adds retry metrics to X-Goog-Api-Client header.
Format will be:
X-Goog-Api-Client: gccl-invocation-id/7a808dc9-2865-4777-beee-cf8259ef7fe0 gccl-attempt-count/1 gl-go/1.18.0 gccl/1.22.0
Does not include uploads & downloads, or experimental gRPC methods. Support for these will be added later.