Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub): add AckWithResult and NackWithResult to message #6201

Merged
merged 12 commits into from
Jun 29, 2022
Merged

feat(pubsub): add AckWithResult and NackWithResult to message #6201

merged 12 commits into from
Jun 29, 2022

Commits on Jun 16, 2022

  1. add AckResult and related methods

    @hongalex
    hongalex committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    fb01253 View commit details
    Browse the repository at this point in the history

  2. feat(pubsub): add AckWithResult and NackWithResult to message

    @hongalex
    hongalex committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    6327975 View commit details
    Browse the repository at this point in the history

  3. feat(pubsub): add AckWithResult and NackWithResult to message

    @hongalex
    hongalex committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    17d96f9 View commit details
    Browse the repository at this point in the history

  4. add comments for AckResult and bring over AcknowledgeStatus from inte… 

    …rnal
    @hongalex
    hongalex committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    9f58224 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. update function definition for IgnoreExported in tests

    @hongalex
    hongalex committed Jun 17, 2022
    Configuration menu
    Copy the full SHA
    06f21cb View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. temporarily update internal/pubsub for samples test

    @hongalex
    hongalex committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    c170640 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. change enum naming to AcknowledgeStatus

    @hongalex
    hongalex committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    9b6917c View commit details
    Browse the repository at this point in the history

  2. remove extra enums in temp internal message.go

    @hongalex
    hongalex committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    acdd6c4 View commit details
    Browse the repository at this point in the history

  3. remove internal/pubsub/message.go

    @hongalex
    hongalex committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ae6d493 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. fix style issues with variadic function options

    @hongalex
    hongalex committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    c213114 View commit details
    Browse the repository at this point in the history

  2. add back comment format to exported const

    @hongalex
    hongalex committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    f2566c9 View commit details
    Browse the repository at this point in the history

  3. keep track of AckResults if exactly once is enabled

    @hongalex
    hongalex committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    7358770 View commit details
    Browse the repository at this point in the history