-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add maxAttempts RetryOption #9215
feat(storage): add maxAttempts RetryOption #9215
Conversation
ecdd447
to
7af9602
Compare
1582407
to
fbb30ff
Compare
ff5f087
to
c154295
Compare
ae12811
to
03aa6fe
Compare
This seems to have been missed in an earlier update and now presubmits are failing on googleapis#9215
b20899c
to
17890c9
Compare
27e4d50
to
ca327a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the pointer implementation for the field in retryConfig, it should be unnecessary to do any manipulation of the Policy logic. Otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more docs clarification, otherwise looks good -- feel free to fix & merge.
Issue: By specifying a count limit for retries using max-retry-count, we can ensure that applications stop automatically retrying operations after that count. This allows you to proactively detect and investigate any persistent issues, rather than letting applications keep attempting to retry indefinitely. This can be particularly beneficial for troubleshooting purposes, as it helps pinpoint the root cause of the failure more quickly.
Adding to configure max retry count in RetryOption to the storage package.
Testing details
Manual - NA
Unit tests - Added
Integration tests - NA