-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Chain cause exception to service exception in translateAndThrow (#946)
* Chain cause exception to service exception in translateAndThrow * Make exception constructors package scoped, better test coverage * Make exception classes final with public constructors
- Loading branch information
Showing
11 changed files
with
287 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
138 changes: 138 additions & 0 deletions
138
gcloud-java-dns/src/test/java/com/google/cloud/dns/DnsExceptionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| /* | ||
| * Copyright 2016 Google Inc. All Rights Reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.cloud.dns; | ||
|
|
||
| import static org.easymock.EasyMock.createMock; | ||
| import static org.easymock.EasyMock.expect; | ||
| import static org.easymock.EasyMock.replay; | ||
| import static org.easymock.EasyMock.verify; | ||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertFalse; | ||
| import static org.junit.Assert.assertNull; | ||
| import static org.junit.Assert.assertSame; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| import com.google.api.client.googleapis.json.GoogleJsonError; | ||
| import com.google.cloud.BaseServiceException; | ||
| import com.google.cloud.RetryHelper.RetryHelperException; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| import java.io.IOException; | ||
| import java.net.SocketTimeoutException; | ||
|
|
||
| public class DnsExceptionTest { | ||
|
|
||
| @Test | ||
| public void testDnsException() throws Exception { | ||
| IOException cause = new SocketTimeoutException("socketTimeoutMessage"); | ||
| DnsException exception = new DnsException(500, "message", cause); | ||
| assertEquals(500, exception.code()); | ||
| assertEquals("message", exception.getMessage()); | ||
| assertNull(exception.reason()); | ||
| assertTrue(exception.retryable()); | ||
| assertTrue(exception.idempotent()); | ||
| assertSame(cause, exception.getCause()); | ||
|
|
||
| exception = new DnsException(502, "message", cause); | ||
| assertEquals(502, exception.code()); | ||
| assertEquals("message", exception.getMessage()); | ||
| assertNull(exception.reason()); | ||
| assertTrue(exception.retryable()); | ||
| assertTrue(exception.idempotent()); | ||
| assertSame(cause, exception.getCause()); | ||
|
|
||
| exception = new DnsException(503, "message", cause); | ||
| assertEquals(503, exception.code()); | ||
| assertEquals("message", exception.getMessage()); | ||
| assertNull(exception.reason()); | ||
| assertTrue(exception.retryable()); | ||
| assertTrue(exception.idempotent()); | ||
| assertSame(cause, exception.getCause()); | ||
|
|
||
| exception = new DnsException(429, "message", cause); | ||
| assertEquals(429, exception.code()); | ||
| assertEquals("message", exception.getMessage()); | ||
| assertNull(exception.reason()); | ||
| assertTrue(exception.retryable()); | ||
| assertTrue(exception.idempotent()); | ||
| assertSame(cause, exception.getCause()); | ||
|
|
||
| exception = new DnsException(404, "message", cause); | ||
| assertEquals(404, exception.code()); | ||
| assertEquals("message", exception.getMessage()); | ||
| assertNull(exception.reason()); | ||
| assertFalse(exception.retryable()); | ||
| assertTrue(exception.idempotent()); | ||
| assertSame(cause, exception.getCause()); | ||
|
|
||
| exception = new DnsException(cause, true); | ||
| assertEquals(DnsException.UNKNOWN_CODE, exception.code()); | ||
| assertNull(exception.reason()); | ||
| assertEquals("socketTimeoutMessage", exception.getMessage()); | ||
| assertEquals(cause, exception.getCause()); | ||
| assertTrue(exception.retryable()); | ||
| assertTrue(exception.idempotent()); | ||
| assertSame(cause, exception.getCause()); | ||
|
|
||
| GoogleJsonError error = new GoogleJsonError(); | ||
| error.setCode(503); | ||
| error.setMessage("message"); | ||
| exception = new DnsException(error, true); | ||
| assertEquals(503, exception.code()); | ||
| assertEquals("message", exception.getMessage()); | ||
| assertTrue(exception.retryable()); | ||
| assertTrue(exception.idempotent()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTranslateAndThrow() throws Exception { | ||
| IOException timeoutException = new SocketTimeoutException("message"); | ||
| Exception cause = new DnsException(timeoutException, true); | ||
| RetryHelperException exceptionMock = createMock(RetryHelperException.class); | ||
| expect(exceptionMock.getCause()).andReturn(cause).times(2); | ||
| replay(exceptionMock); | ||
| try { | ||
| DnsException.translateAndThrow(exceptionMock); | ||
| } catch (BaseServiceException ex) { | ||
| assertEquals(DnsException.UNKNOWN_CODE, ex.code()); | ||
| assertNull(ex.reason()); | ||
| assertEquals("message", ex.getMessage()); | ||
| assertEquals(timeoutException, ex.getCause()); | ||
| assertTrue(ex.retryable()); | ||
| assertTrue(ex.idempotent()); | ||
| } finally { | ||
| verify(exceptionMock); | ||
| } | ||
| cause = new IllegalArgumentException("message"); | ||
| exceptionMock = createMock(RetryHelperException.class); | ||
| expect(exceptionMock.getMessage()).andReturn("message").times(1); | ||
| expect(exceptionMock.getCause()).andReturn(cause).times(2); | ||
| replay(exceptionMock); | ||
| try { | ||
| DnsException.translateAndThrow(exceptionMock); | ||
| } catch (BaseServiceException ex) { | ||
| assertEquals(DnsException.UNKNOWN_CODE, ex.code()); | ||
| assertEquals("message", ex.getMessage()); | ||
| assertFalse(ex.retryable()); | ||
| assertTrue(ex.idempotent()); | ||
| assertSame(cause, ex.getCause()); | ||
| } finally { | ||
| verify(exceptionMock); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.