-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefaultStorageRpc.read setting wrong range #373
Comments
Yes, I think you are right. I think consequences of this bug are minor and basically turns our chunkSize max to be Am I correct? Regardless, good catch and it should be fixed. I am actually more concern though about googleapis/google-api-java-client#937 as it will impact large downloads. (maybe we should send them a PR...) |
Yes exactly that was the problem I experienced when doing some tests for #359, a single byte was unexpectedly left to be read. I am happy to send a PR to fix googleapis/google-api-java-client#937 |
…urcemanager to v1-rev20210215-1.31.0 (googleapis#373)
🤖 I have created a release \*beep\* \*boop\* --- ### [0.118.9](https://www.github.com/googleapis/java-resourcemanager/compare/v0.118.8...v0.118.9) (2021-02-22) ### Dependencies * update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20210215-1.31.0 ([googleapis#373](https://www.github.com/googleapis/java-resourcemanager/issues/373)) ([54f841a](https://www.github.com/googleapis/java-resourcemanager/commit/54f841a6b1f9210a6f52a95cdc0e36e5a545c5a0)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.19.0 ([googleapis#377](https://www.github.com/googleapis/java-resourcemanager/issues/377)) ([d453ff5](https://www.github.com/googleapis/java-resourcemanager/commit/d453ff54471e6f6c01e8fe19061f59d21d0e5ffb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…onfig to v1.5.1 (#373) * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…onfig to v1.5.3 (#373) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.2` -> `1.5.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/compatibility-slim/1.5.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.3/confidence-slim/1.5.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​153-httpsgithubcomgoogleapisjava-shared-configcomparev152v153-2022-07-27) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.5.2...v1.5.3) ##### Dependencies - update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#​497](https://togithub.com/googleapis/java-shared-config/issues/497)) ([1fc6ab4](https://togithub.com/googleapis/java-shared-config/commit/1fc6ab445624cd4f9c8b161d109f346a9e5ed09a)) - Update doclet to latest version 1.6.0 ([38fb7c3](https://togithub.com/googleapis/java-shared-config/commit/38fb7c3957fb6c9b2da10f9e463cc93a8b80a3a4)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-orgpolicy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjEyNy40In0=-->
…-info-reports-plugin to v3.4.1 (#373) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-transcoder). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjAuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE2MC4xIn0=-->
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.3.10](https://togithub.com/googleapis/java-contact-center-insights/compare/v2.3.9...v2.3.10) (2022-10-10) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.17.0 ([#370](https://togithub.com/googleapis/java-contact-center-insights/issues/370)) ([fc2c615](https://togithub.com/googleapis/java-contact-center-insights/commit/fc2c615b72eb2785743a1204c6de91333a988741)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.17.1 ([#374](https://togithub.com/googleapis/java-contact-center-insights/issues/374)) ([470518b](https://togithub.com/googleapis/java-contact-center-insights/commit/470518bb8a547c1890fa4821f168cbe980eb1447)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.20 ([#369](https://togithub.com/googleapis/java-contact-center-insights/issues/369)) ([f448475](https://togithub.com/googleapis/java-contact-center-insights/commit/f4484757e2b8ff52d46f9e5bfe712af7a0c092c7)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
In DefaultStorageRpc.read we set the content range as:
Accorting to here positions are inclusive, so we should probably do:
downloader.setContentRange(position, (int) position + bytes - 1);
The text was updated successfully, but these errors were encountered: