Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure every java file starts with the Apache license. #1067

Merged
merged 6 commits into from
Jun 23, 2016
Merged

Make sure every java file starts with the Apache license. #1067

merged 6 commits into from
Jun 23, 2016

Conversation

jean-philippe-martin
Copy link

I used grep -R -L 'LICENSE-2' * | grep '\.java' | grep -v 'generated-sources' to find those files; I changed them all (including some outside of NIO).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2016
aozarov
aozarov reviewed Jun 21, 2016
View reviewed changes
gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryError.java
@@ -1,3 +1,18 @@
/*

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@jart
Copy link

jart commented Jun 21, 2016

Unrelated side note: Why doesn't this project follow go/releasing/authors and go/releasing/contributions?

@aozarov
Copy link
Contributor

aozarov commented Jun 21, 2016

Unrelated side note: Why doesn't this project follow go/releasing/authors and go/releasing/contributions?

We probably should at some point, but considering what is says in go/releasing/contributions I don't think it matters that much at this point. Also, a discussion about it should probably be in gcloud-common.

@jean-philippe-martin
Copy link
Author

@aozarov

I've added checks. They work from the IDE, but not from the command line. It looks like they have a different idea of what CWD is:

gcloud-java$ mvn -amd -pl gcloud-java-contrib compile
GCloud Java NIO .................................... FAILURE [  1.203 s]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on project gcloud-java-nio: Failed during checkstyle configuration: cannot initialize module Header - Unable to find: src/main/checkstyle/java.header -> [Help 1]

gcloud-java$ file gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header
gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header: ASCII text

If I change the path to gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header then it works from the command line, but not from the IntelliJ IDE:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (checkstyle) on project gcloud-java-nio: Failed during checkstyle configuration: cannot initialize module Header - Unable to find: gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header -> [Help 1]

Help welcome.

@mziccard
Copy link
Contributor

Out of curiosity: in Intellij do you run the build by selecting gcloud-java or gcloud-java-contrib?

@jean-philippe-martin
Copy link
Author

In intellij I validate gcloud-java-nio by going to the "Maven Projects" tab, right-clicking gcloud-java-nio>validate, and selecting "Run Maven build".

mziccard
mziccard reviewed Jun 21, 2016
View reviewed changes
gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryError.java
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mziccard
Copy link
Contributor

In intellij I validate gcloud-java-nio by going to the "Maven Projects" tab, right-clicking gcloud-java-nio>validate, and selecting "Run Maven build".

This is probably the reason for the error, Intellij runs maven in the gcloud-java-nio directory thus not finding gcloud-java-contrib/gcloud-java-nio/src/main/checkstyle/java.header.

BTW, feel free to remove this check and open an issue for it, I will take care of adding it for the whole project.

@jean-philippe-martin jean-philippe-martin mentioned this pull request Jun 21, 2016
Closed
@jean-philippe-martin
Copy link
Author

With pleasure. I removed it and created issue #1071.

mziccard
mziccard reviewed Jun 22, 2016
View reviewed changes
gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/JobStatistics.java
@@ -1,5 +1,5 @@
/*
* Copyright 2015 Google Inc. All Rights Reserved.
* Copyright 2016 Google Inc. All Rights Reserved.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mziccard mziccard merged commit 867278a into googleapis:gcs-nio Jun 23, 2016
@jean-philippe-martin jean-philippe-martin deleted the stamp_license_everywhere branch June 23, 2016 17:21
mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 29, 2016
@jean-philippe-martin @mziccard
Make sure every java file starts with the Apache license. (googleapis…
16de3c2 
…#1067)
mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 30, 2016
@jean-philippe-martin @mziccard
Make sure every java file starts with the Apache license. (googleapis…
5917ae7 
…#1067)
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
@release-please
chore(main): release 2.3.4 (#1067)
6d152ca 
🤖 I have created a release *beep* *boop*
---


## [2.3.4](googleapis/java-translate@v2.3.3...v2.3.4) (2022-09-15)


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.10 ([#1069](googleapis/java-translate#1069)) ([2bee3ba](googleapis/java-translate@2bee3ba))
* Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1073](googleapis/java-translate#1073)) ([8a869f6](googleapis/java-translate@8a869f6))
* Update dependency com.google.cloud:google-cloud-core to v2.8.9 ([#1066](googleapis/java-translate#1066)) ([69d391c](googleapis/java-translate@69d391c))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1074](googleapis/java-translate#1074)) ([c8bfd65](googleapis/java-translate@c8bfd65))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1077](googleapis/java-translate#1077)) ([aa9ef02](googleapis/java-translate@aa9ef02))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1060](googleapis/java-translate#1060)) ([4d9a7ad](googleapis/java-translate@4d9a7ad))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Nov 16, 2022
@Shabirmean @gcf-owl-bot
cleanup: remove migrated sample (#1067)
4d3e63a 
* cleanup: remove migrated sample

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: remove dangling tests

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-common-proto…
e00de03 
…s to v2.12.0 (#1067)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jean-philippe-martin @jart @aozarov @mziccard @googlebot