Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy documentation from abandoned PR #1076

Merged
merged 1 commit into from
Jun 24, 2016

Conversation

jean-philippe-martin
Copy link

This copies over @jart's documentation improvements. I also took the opportunity to rename FakeStorageRpc's "stuff" member variable and indicate that checksums & etags aren't supported.

cc: @jart, @mziccard

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2016
@jart
Copy link

jart commented Jun 23, 2016

LGTM

@jean-philippe-martin
Copy link
Author

If you don't mind I'll wait for mziccard's OK, and then merge.

@jart
Copy link

jart commented Jun 23, 2016

Looks like I forgot to hit merge. If you want to wait, please amend commit to say:

Improve NIO documentation

Documentation has been added to many methods to clarify the preferred
method for instantiating the library, which is the non-SPI version.

@jart
Copy link

jart commented Jun 23, 2016

Also for posterity, abandoned PR was #770

Documentation has been added to many methods to clarify the preferred
method for instantiating the library, which is the non-SPI version.
@jean-philippe-martin
Copy link
Author

Done, thank you!

@mziccard
Copy link
Contributor

Nice, I believe this docs have big value. Thanks for resurrecting them :)

@mziccard mziccard merged commit 7cdcb6c into googleapis:gcs-nio Jun 24, 2016
@jean-philippe-martin jean-philippe-martin deleted the copy_docs branch June 24, 2016 16:43
mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 29, 2016
Documentation has been added to many methods to clarify the preferred
method for instantiating the library, which is the non-SPI version.
mziccard pushed a commit to mziccard/gcloud-java that referenced this pull request Jun 30, 2016
Documentation has been added to many methods to clarify the preferred
method for instantiating the library, which is the non-SPI version.
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
🤖 I have created a release *beep* *boop*
---


## [2.3.5](https://togithub.com/googleapis/java-translate/compare/v2.3.4...v2.3.5) (2022-10-03)


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.12 ([#1076](https://togithub.com/googleapis/java-translate/issues/1076)) ([d76889c](https://togithub.com/googleapis/java-translate/commit/d76889cc92fb1cad71d4be4552d68c962deddfed))
* Update dependency com.google.cloud:google-cloud-core to v2.8.13 ([#1083](https://togithub.com/googleapis/java-translate/issues/1083)) ([3819209](https://togithub.com/googleapis/java-translate/commit/3819209e110df183aba335e22b404c6bc415772a))
* Update dependency com.google.cloud:google-cloud-core to v2.8.14 ([#1084](https://togithub.com/googleapis/java-translate/issues/1084)) ([c2e0417](https://togithub.com/googleapis/java-translate/commit/c2e04178b37396435f6c24d180fd67cbf9bfba3c))
* Update dependency com.google.cloud:google-cloud-core to v2.8.15 ([#1085](https://togithub.com/googleapis/java-translate/issues/1085)) ([554b02f](https://togithub.com/googleapis/java-translate/commit/554b02fa2b97ff4841ae35e7e43ab6c72335a97e))
* Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#1087](https://togithub.com/googleapis/java-translate/issues/1087)) ([dc3663e](https://togithub.com/googleapis/java-translate/commit/dc3663e29574467bd25400c7d91bd0c1ca036038))
* Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1090](https://togithub.com/googleapis/java-translate/issues/1090)) ([982faf0](https://togithub.com/googleapis/java-translate/commit/982faf0eba19064a3b82ad45c2567e613aa225e9))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1092](https://togithub.com/googleapis/java-translate/issues/1092)) ([34fd42e](https://togithub.com/googleapis/java-translate/commit/34fd42e19a494aebfd1f6ab73274ed5b38f175a4))
* Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#1078](https://togithub.com/googleapis/java-translate/issues/1078)) ([06861c1](https://togithub.com/googleapis/java-translate/commit/06861c153ec52be12b8d2e891482bdef76f0a850))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Nov 16, 2022
…1076)

* chore(java): add a note in README for migrated split repos

Disable renovate bot and flaky bot for split repositories
that have moved to the Java monorepo.
The Java monorepo will pass the "monorepo=True" parameter
to java.common_templates method in its owlbot.py files so that
the migration note will not appear in the README in the monorepo.

Co-authored-by: Jeff Ching <[email protected]>
Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
suztomo pushed a commit that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants