chore: update hermetic build workflow #11114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Sep 3, 2024
| exit 1 | ||
| fi | ||
|
|
||
| if [ -z "${generation_config}" ]; then | ||
| generation_config=generation_config.yaml | ||
| echo "Use default generation config: ${generation_config}" |
There was a problem hiding this comment.
Can we keep the image tag as a parameter? In long term, we do want to pass it in and remove the generator version from the generation_config.yaml.
There was a problem hiding this comment.
Sorry I missed this comment. I'll create a follow up.
blakeli0
reviewed
Sep 3, 2024
| # commit the change to the pull request. | ||
| git add java-* pom.xml gapic-libraries-bom/pom.xml versions.txt | ||
| if [[ $(basename "$(pwd)") == "google-cloud-java" ]]; then |
There was a problem hiding this comment.
Do we have to differentiate between google-cloud-java and java-* repos? Can we just do git add .?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
This workflow will serve as a source of true for generation workflows in handwritten libraries.