Remove unused dependencies from contrib, NIO and NIO examples #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mziccard
reviewed
Oct 24, 2016
| @@ -23,7 +23,7 @@ | |||
| <dependencies> | |||
| <dependency> | |||
| <groupId>${project.groupId}</groupId> | |||
| <artifactId>google-cloud</artifactId> | |||
| <artifactId>google-cloud-storage</artifactId> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mziccard
reviewed
Oct 24, 2016
| @@ -71,6 +71,7 @@ | |||
| <groupId>org.mockito</groupId> | |||
| <artifactId>mockito-core</artifactId> | |||
| <version>1.9.5</version> | |||
| <scope>test</scope> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mziccard
changed the title
|
@jean-philippe-martin Thanks for this! |
|
Thanks for fixing the title, @mziccard ! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…1575) (#1333) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #1332:
mockito-coreto test scopegoogle-cloud-niodependency togoogle-cloud-storagerather thangoogle-cloudThe google-cloud-nio-example test passes, as expected.
cc: @mziccard