Add better javadoc and snippets for Datastore and Transaction #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lesv
suggested changes
Nov 1, 2016
| * For entities with complete keys that were marked for deletion in this writer the operation | ||
| * will be changed to {@link #put}. | ||
| * | ||
| * @throws DatastoreException if a given entity with the same complete key was already added to | ||
| * this writer, if writer is not active or if id allocation for an entity with an incomplete | ||
| * key failed. | ||
| * key failed |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -176,6 +176,205 @@ | |||
| <T> QueryResults<T> run(Query<T> query); | |||
|
|
|||
| /** | |||
| * Datastore add operation. This method will also allocate id for any entity with an incomplete | |||
| * key. As opposed to {@link #add(FullEntity)} and {@link #add(FullEntity...)}, this method will | |||
| * defer any necessary id allocation to commit time. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lesv
approved these changes
Nov 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
putandaddinDatastore,BatchandTransactionTransaction'sput,add,update,delete,addWithDeferredIdAllocationandputWithDeferredIdAllocationDatastore'saddFixes #1339
@unitydynamics feel free to comment :)
/cc @lesv