Use returnImmediately=false and disable timeouts for pullAsync #1387
Conversation
googlebot
added
the
cla: yes
|
This fixes #1157 /cc @garrettjonesgoogle @aozarov care to have a look? |
|
LGTM |
| PullRequest request = PullRequest.newBuilder().setReturnImmediately(true) | ||
| .setSubscription( | ||
| SubscriberApi.formatSubscriptionName(getOptions().getProjectId(), subscription)) | ||
| .setMaxMessages(maxMessages) | ||
| .setReturnImmediately(true) | ||
| .setReturnImmediately(returnImmediately) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good to me. One minor comment. Also, another suggestion that even I am not too keen about (as it typically frown upon) but still would like to mention. Did you consider adding a finalize to this Future to "cancel" the request if was not completed and finalized? |
Do you think this would be a good choice? I wouldn't rely on |
Perfect! Then surely there is no need for such (pretty lame) guard. Feel free to merge after removing the redundant |
…9.1 (#1387) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-pubsub](https://togithub.com/googleapis/java-pubsub) | `1.119.0` -> `1.119.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigquerydatatransfer).
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [2.2.4](googleapis/java-bigquerydatatransfer@v2.2.3...v2.2.4) (2022-06-13) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.13.2 ([#1388](googleapis/java-bigquerydatatransfer#1388)) ([5366270](googleapis/java-bigquerydatatransfer@5366270)) * update dependency com.google.cloud:google-cloud-pubsub to v1.119.1 ([#1387](googleapis/java-bigquerydatatransfer#1387)) ([578c028](googleapis/java-bigquerydatatransfer@578c028)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
No description provided.