Add query request and query response classes and tests #452

mziccard · 2015-12-11T23:07:56Z

This PR adds classes for Query Requests and Query Responses:

QueryRequest is used to run queries "on the fly" Jobs: query
QueryResponse is used to both hold the result of queries run on the fly (Jobs: query) and to hold the result of query jobs (Jobs: getQueryResults)

Remarks
QueryResponse has no fromPb method as it is initialized through the builder inside the BigQueryServiceImpl class. This is so because:

we need service and service options to initialize the field Page<List<FieldValue>> rows
QueryResponse is created from 2 pb classes: QueryResponse and GetQueryResultsResponse
I preferred to handle the creation inside BigQueryServiceImpl rather than having a fromPb method with more parameters.

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/QueryRequest.java

+ *
+ * @see <a href="https://cloud.google.com/bigquery/docs/reference/v2/jobs/query">Query</a>
+ */
+public class QueryRequest implements Serializable {


mziccard · 2015-12-14T15:02:34Z

Ehi guys, thanks for the feedback. I fixed all comments and answered the open questions.

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/QueryResponse.java

+
+  private static final long serialVersionUID = 3549226764825005655L;
+
+  private final String etag;


- Add better javadoc and snippet to QueryResponse - Use primitive boolean for jobComplete - Add test for NPE in QueryRequestTests - Add QueryRequest and QueryResponse to SerializationTest

mziccard · 2015-12-14T21:27:40Z

@ajkannan I fixed the typo in 9756dff
@aozarov I added the QueryResult class in e16c027

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/SerializationTest.java

@@ -212,7 +233,7 @@ public void testModelAndRequests() throws Exception {
        TABLE_SCHEMA, TABLE_INFO, VIEW_INFO, EXTERNAL_TABLE_INFO, INLINE_FUNCTION, URI_FUNCTION,
        JOB_STATISTICS, EXTRACT_STATISTICS, LOAD_STATISTICS, QUERY_STATISTICS, BIGQUERY_ERROR,
        JOB_STATUS, JOB_ID, COPY_JOB, EXTRACT_JOB, LOAD_JOB, QUERY_JOB, INSERT_ALL_REQUEST,
-        INSERT_ALL_RESPONSE, FIELD_VALUE};
+        INSERT_ALL_RESPONSE, FIELD_VALUE, QUERY_REQUEST, QUERY_RESPONSE};


aozarov · 2015-12-14T22:23:19Z

Looks great! I have few more questions/nits.

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/QueryResultTest.java

+      .build();
+
+  @Test
+  public void testBuilder() {


… list, add hasErrors

mziccard · 2015-12-14T22:50:33Z

c6e53c8 fixes latest comments and makes checkstyle happy

Add query request and query response classes and tests

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

…admin to v0.13.1 (#452) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.analytics:google-analytics-admin](https://togithub.com/googleapis/java-analytics-admin) | `0.13.0` -> `0.13.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.1/compatibility-slim/0.13.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.analytics:google-analytics-admin/0.13.1/confidence-slim/0.13.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-analytics-admin</summary> ### [`v0.13.1`](https://togithub.com/googleapis/java-analytics-admin/blob/HEAD/CHANGELOG.md#0131-httpsgithubcomgoogleapisjava-analytics-admincomparev0130v0131-2022-09-08) [Compare Source](https://togithub.com/googleapis/java-analytics-admin/compare/v0.13.0...v0.13.1) ##### Dependencies - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#449](https://togithub.com/googleapis/java-analytics-admin/issues/449)) ([8c5f1da](https://togithub.com/googleapis/java-analytics-admin/commit/8c5f1da3106dd990fa815ce2bf3ab4f63389fd82)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-analytics-admin).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jinja2](https://palletsprojects.com/p/jinja/) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.0.3` -> `==3.1.2` | [![age](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/compatibility-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/confidence-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).

Add query request and query response classes and tests

20d4841

mziccard added the api: bigquery Issues related to the BigQuery API. label Dec 11, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 11, 2015

ajkannan reviewed Dec 11, 2015
View reviewed changes

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/QueryRequest.java

*

* @see <a href="https://cloud.google.com/bigquery/docs/reference/v2/jobs/query">Query</a>

*/

public class QueryRequest implements Serializable {

This comment was marked as spam.

Sign in to view

aozarov reviewed Dec 14, 2015
View reviewed changes

gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/QueryResponse.java

private static final long serialVersionUID = 3549226764825005655L;

private final String etag;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Refactor QueryRequest and QueryResponse

9756dff

- Add better javadoc and snippet to QueryResponse - Use primitive boolean for jobComplete - Add test for NPE in QueryRequestTests - Add QueryRequest and QueryResponse to SerializationTest

mziccard force-pushed the bigquery branch from 903d3c6 to ea54699 Compare December 14, 2015 21:26

Add QueryResult class and tests

e16c027

mziccard force-pushed the bigquery branch from 3324243 to e16c027 Compare December 14, 2015 22:05

ajkannan reviewed Dec 14, 2015
View reviewed changes

gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/QueryResultTest.java

.build();

@Test

public void testBuilder() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Rename QueryResponse.job to jobId, better javadoc, no errors as empty…

c6e53c8

… list, add hasErrors

aozarov added a commit that referenced this pull request Dec 14, 2015

Merge pull request #452 from mziccard/bigquery

36c7406

Add query request and query response classes and tests

aozarov merged commit 36c7406 into googleapis:bigquery Dec 14, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add query request and query response classes and tests #452

Add query request and query response classes and tests #452

mziccard commented Dec 11, 2015

This comment was marked as spam.

mziccard commented Dec 14, 2015

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Dec 14, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Dec 14, 2015

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Dec 14, 2015


		private static final long serialVersionUID = 3549226764825005655L;

		private final String etag;

Add query request and query response classes and tests #452

Add query request and query response classes and tests #452

Conversation

mziccard commented Dec 11, 2015

This comment was marked as spam.

mziccard commented Dec 14, 2015

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Dec 14, 2015

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Dec 14, 2015

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Dec 14, 2015