Import firestore conformance tests from googleapis/conformance-tests@32fd66cf7dffe8431643f08b5944108ac10c8bc2

[BenWhitehead]

• Add new script generate-conformance-tests.sh that can reliably update
    the various files that make up the conformance tests.
    * Currently the script only updates firestore tests.
    * Updating of the git-submodule linking to conformance-tests is not
      done by the script, it is expected that the developer will do the
      bumping.
• import proto definition
• generate updated TestDefinition from definition
• Add individual test files
• Add maven profile gen-conformance-protos that can be used to generate protos in com.google.cloud:google-cloud-conformance-tests

Depends on #5540

[BenWhitehead]

@kolea2 Please review

[chingor13]

Are all the languages using submodules for reading the tests?

[BenWhitehead]

Are all the languages using submodules for reading the tests?

They are starting to move in that direction. dotnet is already using sub-module, and ruby is going to move when updating the firestore tests.

I will note, the submodule here is purely to track the commit the resources are from, the sub-module does not need to be cloned for the tests to run. The script generate-conformance-tests.sh copies and generates everything into the correct location so the tests can run.

[codecov]

Codecov Report

Merging #5541 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5541      +/-   ##
============================================
- Coverage     46.71%   46.71%   -0.01%     
+ Complexity    24630    24624       -6     
============================================
  Files          2351     2351              
  Lines        256127   256121       -6     
  Branches      29325    29323       -2     
============================================
- Hits         119650   119645       -5     
+ Misses       127558   127557       -1     
  Partials       8919     8919

Impacted Files	Coverage Δ	Complexity Δ
...able/gaxx/reframing/ReframingResponseObserver.java	88.99% <0%> (-1.84%)	29% <0%> (-1%)
...om/google/cloud/bigtable/data/v2/models/Query.java	66.32% <0%> (-0.35%)	22% <0%> (-3%)
...ogle/cloud/talent/v4beta1/TenantServiceClient.java	59.25% <0%> (ø)	22% <0%> (ø)	⬇️
...oogle/cloud/talent/v4beta1/EventServiceClient.java	42.42% <0%> (ø)	7% <0%> (ø)	⬇️
.../google/cloud/talent/v4beta1/JobServiceClient.java	45.69% <0%> (ø)	34% <0%> (ø)	⬇️
...cloud/talent/v4beta1/ApplicationServiceClient.java	61.17% <0%> (ø)	23% <0%> (ø)	⬇️
...gle/cloud/talent/v4beta1/CompanyServiceClient.java	59.25% <0%> (ø)	22% <0%> (ø)	⬇️
...gle/cloud/talent/v4beta1/ProfileServiceClient.java	47.52% <0%> (ø)	22% <0%> (ø)	⬇️
...src/main/java/com/google/cloud/ServiceOptions.java	40.61% <0%> (+0.35%)	27% <0%> (-2%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d709c...c5dce8f. Read the comment docs.

[BenWhitehead]

The builds are currently failing because I need to rebase them. Since this PR is dependent on another PR I'll wait to rebase until that PR is merged. The changes in the PR are unrelated to the build failures and can still be reviewed.

[BenWhitehead]

Rebased after merge of #5540 and ready for review.

[kolea2]

Just for my understanding, what does this do?

[BenWhitehead]

This file is the definition for the git-submodule which is being used to track which revision the local conformance test resources came from. You can see an example of what it looks like and how it exists in the file tree here.

[kolea2]

(can't comment on the file as it is too big) Is TestDefinition.java generated or hand written?

[BenWhitehead]

(can't comment on the file as it is too big) Is TestDefinition.java generated or hand written?

TestDefinition.java is generated from tests.proto.

[kolea2]

LGTM, @chingor13 do you have any final comments?

[chingor13]

LGTM, but can you add a bit more info on the README for the conformance tests on the relationship between the test protos and the json config files?

[BenWhitehead]

@chingor13 Added some details to the README to explain the files and their relationships. I've also rebased the PR on master.