Spanner: Add specific timeout for Partitioned DML with default of 2 hours #5709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
olavloite
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5709 +/- ##
=========================================
Coverage 46.72% 46.72%
Complexity 24647 24647
=========================================
Files 2351 2351
Lines 256149 256149
Branches 29327 29327
=========================================
Hits 119688 119688
Misses 127539 127539
Partials 8922 8922Continue to review full report at Codecov.
|
kolea2
suggested changes
Jul 9, 2019
| .setChannelProvider(channelProvider) | ||
| .setCredentials(NoCredentials.getInstance()); | ||
| // Set normal DML timeout value. | ||
| builder.getSpannerStubSettingsBuilder().executeSqlSettings().setRetrySettings(retrySettings); |
There was a problem hiding this comment.
Is it possible to add an assertion that the PDML timeout is 2 hrs?
kolea2
suggested changes
Jul 9, 2019
| @@ -114,6 +116,7 @@ private SpannerOptions(Builder builder) { | |||
| } catch (IOException e) { | |||
| throw SpannerExceptionFactory.newSpannerException(e); | |||
| } | |||
| partitionedDmlTimeout = builder.partitionedDmlTimeout; | |||
There was a problem hiding this comment.
very minor - I would move this above the try-catch, after sessionLabels.
kolea2
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partitioned DML statements should use a different timeout value than the default timeout value used for normal queries and update statements, as these could be long running. This PR adds a default timeout of 2 hours for Partitioned DML statements and an extra configuration option for setting the timeout.