Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Pub/Sub publisher docstring example #6100

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Aug 16, 2019

Fixes #3920

Missed the docstring in a previous PR #4120 that addressed the same issue.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2019
@anguillanneuf anguillanneuf changed the title docs: update docstring for ApiFutures.addCallback() in Pub/Sub docs: update Pub/Sub publisher docstring example Aug 19, 2019
@anguillanneuf
Copy link
Contributor Author

@chingor13 Do you know why the test kept failing?

@chingor13
Copy link
Contributor

It looks like a flakey spanner JDBC test. @kolea2, @olavloite might know more.

@kolea2
Copy link
Contributor

kolea2 commented Aug 20, 2019

Sorry about that, we're tracking #6075 to fix this. I've rerun the build.

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #6100 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6100      +/-   ##
============================================
+ Coverage     47.38%    47.4%   +0.01%     
- Complexity    27180    27228      +48     
============================================
  Files          2523     2523              
  Lines        274580   274830     +250     
  Branches      31380    31391      +11     
============================================
+ Hits         130118   130289     +171     
- Misses       134852   134928      +76     
- Partials       9610     9613       +3
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.11% <ø> (ø) 40 <0> (ø) ⬇️
...gtable/admin/v2/BigtableInstanceAdminSettings.java 97.77% <0%> (-2.23%) 11% <0%> (+5%)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 60.56% <0%> (-1.44%) 25% <0%> (+6%)
.../bigtable/admin/v2/BigtableTableAdminSettings.java 73.25% <0%> (+1.51%) 14% <0%> (+7%) ⬆️
...e/cloud/bigtable/data/v2/BigtableDataSettings.java 37.2% <0%> (+2.42%) 4% <0%> (+1%) ⬆️
...d/dialogflow/v2beta1/SessionEntityTypesClient.java 64.77% <0%> (+4.99%) 39% <0%> (+16%) ⬆️
.../cloud/dialogflow/v2/SessionEntityTypesClient.java 66.02% <0%> (+6.24%) 36% <0%> (+13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81aad64...7294775. Read the comment docs.

@chingor13 chingor13 merged commit 3909ebd into master Aug 21, 2019
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch August 21, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pub/Sub: ApiFutures.addCallback() deprecated in code example
5 participants