Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turned ChangeRequest into a functional object. #789

Merged
merged 2 commits into from
Mar 26, 2016
Merged

Turned ChangeRequest into a functional object. #789

merged 2 commits into from
Mar 26, 2016

Commits on Mar 25, 2016

  1. Turned ChangeRequest into a functional object.

    @mderka
    mderka committed Mar 25, 2016
    Configuration menu
    Copy the full SHA
    01e2310 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2016

  1. Addressed comments. This includes: 

    - Moved Status enum to ChangeRequestInfo.
- Switching from ChangeRequest.builer() to ChangeRequestInfo.builder()
- Fixing README accordingly
- Used times() for mocking instead of repeated expect()
- Snippets and documentation work with ChangeRequestInfo. Fixes googleapis#788.
- Equals uses getClass instead if instanceof.
- Removed unnecessary imports.
    @mderka
    mderka committed Mar 26, 2016
    Configuration menu
    Copy the full SHA
    de8bf4b View commit details
    Browse the repository at this point in the history