Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [maps-mapsplatformdatasets] new module for maps-mapsplatformdatasets #9159

Merged
merged 3 commits into from
Feb 27, 2023
Merged

feat: [maps-mapsplatformdatasets] new module for maps-mapsplatformdatasets #9159

merged 3 commits into from
Feb 27, 2023

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Feb 25, 2023 •
edited
Loading

Supersedes previous attempt in #9119.

Initial generation for new mapsplatformdatasets client library:

python3.9 generation/new_client/new-client.py generate \
  --api_shortname=maps-mapsplatformdatasets \
  --proto-path=google/maps/mapsplatformdatasets \
  --name-pretty="Maps Platform Datasets API" \
  --product-docs="https://developers.google.com/maps/documentation" \
  --api-description="The Maps Platform Datasets API enables developers to ingest geospatially-tied datasets
    that they can use to enrich their experience of Maps Platform solutions (e.g. styling, routing)." \
  --cloud-api=false \
  --distribution-name="com.google.maps:google-maps-mapsplatformdatasets"

emmileaf
emmileaf commented Feb 25, 2023
View reviewed changes
java-maps-mapsplatformdatasets/.repo-metadata.json
{
"api_shortname": "maps-mapsplatformdatasets",
"name_pretty": "Maps Platform Datasets API",
"product_documentation": "https://developers.google.com/maps/documentation",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parent product homepage is a placeholder for the product documentation link which is not yet available, but our script requires something starting with "https://".

@emmileaf emmileaf marked this pull request as ready for review February 25, 2023 00:41
@snippet-bot
Copy link

snippet-bot bot commented Feb 25, 2023

Here is the summary of possible violations 😱

There are 34 possible violations for not having product prefix.

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 34 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2023
suztomo
suztomo approved these changes Feb 27, 2023
View reviewed changes
java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets/pom.xml
<?xml version="1.0"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.maps</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group ID looks good.

java-maps-mapsplatformdatasets/grpc-google-maps-mapsplatformdatasets-v1alpha/pom.xml
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.maps.api.grpc</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group ID looks good.

java-maps-mapsplatformdatasets/google-maps-mapsplatformdatasets-bom/pom.xml
<?xml version="1.0"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.maps</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group ID looks good.

@suztomo
Copy link
Member

suztomo commented Feb 27, 2023

"snippet-bot check" fails because this is not Cloud product. It's fine.

@emmileaf emmileaf merged commit c8e3fc0 into main Feb 27, 2023
@emmileaf emmileaf deleted the new_module_java-maps-mapsplatformdatasets branch February 27, 2023 14:17
This was referenced Feb 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@JoeWang1127 JoeWang1127 Awaiting requested review from JoeWang1127

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmileaf @suztomo