Skip to content

Commit

Permalink
fix!: rename the type FunnelFilter to FunnelFieldFilter (#218)
Browse files Browse the repository at this point in the history
fix!: rename the `funnel_filter` field of the `FunnelFilterExpression` type to `funnel_field_filter`
PiperOrigin-RevId: 455204231
Source-Link: googleapis/googleapis@4849480
Source-Link: googleapis/googleapis-gen@589642d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTg5NjQyZDBhNjhhMmM1MTkyNzNjZjBmN2Q3OTQ3YjE5Y2Q5OWVhYyJ9
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
  • Loading branch information
gcf-owl-bot[bot] and gcf-owl-bot[bot] authored Jun 20, 2022
1 parent a4ba525 commit 5f9bc6c
Show file tree
Hide file tree
Showing 8 changed files with 162 additions and 151 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ message RunFunnelReportRequest {

// If specified, next action adds a dimension to the funnel visualization sub
// report response. This next action dimension expands each funnel step to the
// unique values of the next action. For example a breakdown by the
// unique values of the next action. For example a next action of the
// `eventName` dimension will create rows for several events (i.e.
// `session_start` & `click`) and the total.
//
// Next action only supports `eventName` and most Page / Screen dimensions
// like `pageTitle` and `pagePath`.
FunnelNextAction funnel_next_action = 5;

// The funnel visualization type controls the dimensions present in the funnel
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,10 @@ message FunnelNextAction {
// The dimension column added to the funnel visualization sub report response.
// The next action dimension returns the next dimension value of this
// dimension after the user has attained the `i`th funnel step.
// `nextActionDimension` currently only supports the `eventName` dimension.
//
// `nextActionDimension` currently only supports `eventName` and most Page /
// Screen dimensions like `pageTitle` and `pagePath`. `nextActionDimension`
// cannot be a dimension expression.
Dimension next_action_dimension = 1;

// The maximum number of distinct values of the breakdown dimension to return
Expand Down Expand Up @@ -1026,8 +1029,8 @@ message FunnelFilterExpression {
// The FunnelFilterExpression is NOT of `notExpression`.
FunnelFilterExpression not_expression = 3;

// A primitive funnel filter.
FunnelFilter funnel_filter = 4;
// A funnel filter for a dimension or metric.
FunnelFieldFilter funnel_field_filter = 4;

// Creates a filter that matches events of a single event name. If a
// parameter filter expression is specified, only the subset of events that
Expand All @@ -1044,7 +1047,7 @@ message FunnelFilterExpressionList {
}

// An expression to filter dimension or metric values.
message FunnelFilter {
message FunnelFieldFilter {
// The dimension name or metric name.
string field_name = 1;

Expand Down
90 changes: 45 additions & 45 deletions packages/google-analytics-data/protos/protos.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5f9bc6c

Please sign in to comment.