core (grpc): correctly convert arrays & bools (#1329)

googleapis · May 18, 2016 · 79b05af · 79b05af
1 parent 0fdff64
commit 79b05af
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/lib/common/grpc-service.js b/lib/common/grpc-service.js
@@ -322,7 +322,7 @@ GrpcService.convertValue_ = function(value) {
     };
   } else if (is.boolean(value)) {
     convertedValue = {
-      booleanValue: value
+      boolValue: value
     };
   } else if (Buffer.isBuffer(value)) {
     convertedValue = {
@@ -344,7 +344,9 @@ GrpcService.convertValue_ = function(value) {
     };
   } else if (is.array(value)) {
     convertedValue = {
-      listValue: value.map(GrpcService.convertValue_)
+      listValue: {
+        values: value.map(GrpcService.convertValue_)
+      }
     };
   } else {
     throw new Error('Value of type ' + typeof value + ' not recognized.');

diff --git a/system-test/logging.js b/system-test/logging.js
@@ -243,8 +243,12 @@ describe('Logging', function() {
       // object data
       log.entry({ delegate: 'my_username' }),
 
-      // null data
-      log.entry({ nonValue: null }),
+      // various data types
+      log.entry({
+        nonValue: null,
+        boolValue: true,
+        arrayValue: [ 1, 2, 3 ]
+      }),
 
       // nested object data
       log.entry({

diff --git a/test/common/grpc-service.js b/test/common/grpc-service.js
@@ -692,7 +692,7 @@ describe('GrpcService', function() {
       });
 
       assert.deepEqual(GrpcService.convertValue_(true), {
-        booleanValue: true
+        boolValue: true
       });
 
       assert.strictEqual(
@@ -733,11 +733,13 @@ describe('GrpcService', function() {
     it('should convert arrays', function() {
       var convertedValue = GrpcService.convertValue_([1, 2, 3]);
 
-      assert.deepEqual(convertedValue.listValue, [
-        GrpcService.convertValue_(1),
-        GrpcService.convertValue_(2),
-        GrpcService.convertValue_(3)
-      ]);
+      assert.deepEqual(convertedValue.listValue, {
+        values: [
+          GrpcService.convertValue_(1),
+          GrpcService.convertValue_(2),
+          GrpcService.convertValue_(3)
+        ]
+      });
     });
 
     it('should throw if a type is not recognized', function() {