storage: pass metadata during stream upload

googleapis · Feb 2, 2015 · 89b74b0 · 89b74b0
1 parent 5284a39
commit 89b74b0
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/lib/common/util.js b/lib/common/util.js
@@ -304,7 +304,9 @@ function makeWritableStream(dup, options, onComplete) {
       // Write the metadata to the request.
       stream.write('--' + boundary + '\n');
       stream.write('Content-Type: application/json\n\n');
-      stream.write(JSON.stringify(options.metadata));
+      stream.write(JSON.stringify({
+        metadata: options.metadata
+      }));
       stream.write('\n\n');
       stream.write('--' + boundary + '\n');
       stream.write('Content-Type: ' + streamType + '\n\n');

diff --git a/regression/storage.js b/regression/storage.js
@@ -374,9 +374,12 @@ describe('storage', function() {
           });
       });
 
-      it('should write metadata', function(done) {
+      it.only('should write metadata', function(done) {
         var options = {
-          metadata: { contentType: 'image/png' },
+          metadata: {
+            contentType: 'image/png',
+            property: 'value'
+          },
           resumable: false
         };
 
@@ -386,6 +389,7 @@ describe('storage', function() {
           file.getMetadata(function(err, metadata) {
             assert.ifError(err);
             assert.equal(metadata.contentType, options.metadata.contentType);
+            assert.equal(metadata.metadata.property, options.metadata.property);
             file.delete(done);
           });
         });

diff --git a/test/common/util.js b/test/common/util.js
@@ -210,7 +210,9 @@ describe('common/util', function() {
           assert(endFirstBoundaryIdx > startFirstBoundaryIdx);
           assert(endBoundaryIdx > -1);
 
-          assert(written.indexOf(JSON.stringify(metadata)) > -1);
+          assert(written.indexOf(JSON.stringify({
+            metadata: metadata
+          })) > -1);
 
           done();
         };