Merge pull request #880 from stephenplusplus/spp--remove-nan

datastore: assign appropriate ID or name attribute
googleapis · Sep 21, 2015 · 8d24946 · 8d24946
2 parents 5f94d63 + fed292e
commit 8d24946
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/lib/datastore/entity.js b/lib/datastore/entity.js
@@ -21,6 +21,8 @@
 
 'use strict';
 
+var is = require('is');
+
 /** @const {object} Map for query operation -> operation protocol value. */
 var OP_TO_OPERATOR = {
   '=':  'EQUAL',
@@ -223,11 +225,10 @@ function keyToKeyProto(key) {
     var p = { kind: keyPath[i] };
     var val = keyPath[i + 1];
     if (val) {
-      // if not numeric, set key name.
-      if (isNaN(val)) {
-        p.name = val;
-      } else {
+      if (is.number(val)) {
         p.id = val;
+      } else {
+        p.name = val;
       }
     } else if (i < keyPath.length - 2) { // i is second last path item
       throw new Error('Invalid key. Ancestor keys require an id or name.');

diff --git a/test/datastore/entity.js b/test/datastore/entity.js
@@ -192,12 +192,20 @@ describe('keyToKeyProto', function() {
   it('should handle incomplete keys with & without namespaces', function() {
     var key = new entity.Key({ path: [ 'Kind1' ] });
     var keyWithNS = new entity.Key({
-        namespace: 'Namespace',
-        path: [ 'Kind1' ]
-      });
+      namespace: 'Namespace',
+      path: [ 'Kind1' ]
+    });
+    var keyWithNumericID = new entity.Key({
+      path: [ 'Kind1', 234 ]
+    });
+    var keyWithStringID = new entity.Key({
+      path: [ 'Kind1', 'StringId' ]
+    });
 
     var proto = entity.keyToKeyProto(key);
     var protoWithNS = entity.keyToKeyProto(keyWithNS);
+    var protoWithNumericID = entity.keyToKeyProto(keyWithNumericID);
+    var protoWithStringID = entity.keyToKeyProto(keyWithStringID);
 
     assert.strictEqual(proto.partition_id, undefined);
     assert.strictEqual(proto.path_element[0].kind, 'Kind1');
@@ -208,6 +216,9 @@ describe('keyToKeyProto', function() {
     assert.strictEqual(protoWithNS.path_element[0].kind, 'Kind1');
     assert.strictEqual(protoWithNS.path_element[0].id, undefined);
     assert.strictEqual(protoWithNS.path_element[0].name, undefined);
+
+    assert.strictEqual(protoWithNumericID.path_element[0].id, 234);
+    assert.strictEqual(protoWithStringID.path_element[0].name, 'StringId');
   });
 
   it('should throw if key contains 0 items', function() {