Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicated information in runQuery docs #1074

Closed
hrovira opened this issue Jan 19, 2016 · 3 comments
Closed

duplicated information in runQuery docs #1074

hrovira opened this issue Jan 19, 2016 · 3 comments
Assignees
@stephenplusplus
Labels
api: datastore Issues related to the Datastore API.

Comments

@hrovira
Copy link
Contributor

hrovira commented Jan 19, 2016

https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.27.0/datastore/dataset?method=runQuery

the "Parameters" table seems to have dup'd entries for the callback arguments... err, entities, nextQuery, apiResponse, err, entities, nextQuery, apiResponse.

there are slightly different descriptions, so it may have been that the older descriptions did not get deleted.
@stephenplusplus stephenplusplus added docs api: datastore Issues related to the Datastore API. labels Jan 19, 2016
@stephenplusplus
Copy link
Contributor

Oops, we did duplicate these: https://github.com/GoogleCloudPlatform/gcloud-node/blob/v0.27.0/lib/datastore/request.js#L553-L565

Any chance you want to send a PR just removing the extras? The first nextQuery and the second entities are the good ones.

@hrovira hrovira mentioned this issue Jan 20, 2016
Closed
hrovira added a commit to hrovira/gcloud-node that referenced this issue Jan 20, 2016
@hrovira
fixing duplicated parameter description
13a268e 
there were duplicated parameter definitions for 'err', 'callback.entities', 'callback.nextQuery', 'callback.apiResponse'.

fixed by removing redundant.

fixes googleapis#1074
@hrovira
Copy link
Contributor Author

hrovira commented Jan 20, 2016

sorry for the confusion, had to abort 2 PRs, issues with commits... last PR (1080) should be easily merged.

@stephenplusplus
Copy link
Contributor

Fixed in 073dd09.

@sofisl sofisl mentioned this issue Jan 17, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 17, 2023
@release-please @gcf-owl-bot
chore(main): release 3.1.0 (#1074)
a14b7ab 
* chore(main): release 3.1.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes/docs v0.27.0 datastore dataset
2 participants
@hrovira @stephenplusplus