Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore.saveAll should not expect insertAutoIds to always be there #15

Closed
proppy opened this issue Jul 10, 2014 · 1 comment · Fixed by #16
Closed

datastore.saveAll should not expect insertAutoIds to always be there #15

proppy opened this issue Jul 10, 2014 · 1 comment · Fixed by #16
Assignees
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@proppy
Copy link
Contributor

proppy commented Jul 10, 2014

When there is no id allocation the field is undefined.

See proppy@0b953f5 for a quick fix.

@rakyll
Copy link
Contributor

rakyll commented Jul 11, 2014

Can you open a PR?

@jgeewax jgeewax added the api: datastore Issues related to the Datastore API. label Feb 2, 2015
@jgeewax jgeewax modified the milestones: M1: core, datastore & storage, Datastore Stable Feb 2, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
sofisl pushed a commit that referenced this issue Sep 16, 2022
## Features

This minor release contains dependency upgrades and some improvements to the documentation. There should not be any incompatible code changes.
sofisl pushed a commit that referenced this issue Oct 5, 2022
## Features

This minor release contains dependency upgrades and some improvements to the documentation. There should not be any incompatible code changes.
sofisl pushed a commit that referenced this issue Oct 8, 2022
## Features

This minor release contains dependency upgrades and some improvements to the documentation. There should not be any incompatible code changes.
sofisl pushed a commit that referenced this issue Nov 12, 2022
* chore(main): release 0.2.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 12, 2022
sofisl pushed a commit that referenced this issue Nov 16, 2022
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* chore: generate GAPIC metadata JSON file

PiperOrigin-RevId: 345596855

Source-Author: Google APIs <[email protected]>
Source-Date: Thu Dec 3 21:00:34 2020 -0800
Source-Repo: googleapis/googleapis
Source-Sha: d189e871205fea665a9648f7c4676f027495ccaf
Source-Link: googleapis/googleapis@d189e87

* build: change package name to correct name

PiperOrigin-RevId: 355768415

Source-Author: Google APIs <[email protected]>
Source-Date: Thu Feb 4 20:11:51 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: bc89fd90b0dc87b387d83a56b27789f807d9da11
Source-Link: googleapis/googleapis@bc89fd9
sofisl pushed a commit that referenced this issue Nov 16, 2022
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a27e585a-8362-450e-a458-6225be320237/targets

- [ ] To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 361273630
Source-Link: googleapis/googleapis@5477122
sofisl pushed a commit that referenced this issue Dec 21, 2022
🤖 I have created a release *beep* *boop*
---


## [0.1.1](googleapis/nodejs-video-stitcher@v0.1.0...v0.1.1) (2022-06-23)


### Bug Fixes

* **deps:** update dependency google-gax to v3 ([#15](googleapis/nodejs-video-stitcher#15)) ([345085f](googleapis/nodejs-video-stitcher@345085f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Jan 10, 2023
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Feb 23, 2023
🤖 I have created a release *beep* *boop*
---


## [0.2.0](googleapis/nodejs-dataform@v0.1.0...v0.2.0) (2022-09-14)


### Features

* Release API version v1beta1 (no changes to v1alpha2) ([#11](googleapis/nodejs-dataform#11)) ([1ff35a6](googleapis/nodejs-dataform@1ff35a6))


### Bug Fixes

* Allow passing gax instance to client constructor ([#18](googleapis/nodejs-dataform#18)) ([34e62f5](googleapis/nodejs-dataform@34e62f5))
* Better support for fallback mode ([#13](googleapis/nodejs-dataform#13)) ([f48d918](googleapis/nodejs-dataform@f48d918))
* Change import long to require ([#14](googleapis/nodejs-dataform#14)) ([3790bfd](googleapis/nodejs-dataform@3790bfd))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-dataform/issues/1553)) ([#17](googleapis/nodejs-dataform#17)) ([32373fd](googleapis/nodejs-dataform@32373fd))
* Preserve default values in x-goog-request-params header ([#19](googleapis/nodejs-dataform#19)) ([bbb3790](googleapis/nodejs-dataform@bbb3790))
* Remove pip install statements ([#1546](https://github.com/googleapis/nodejs-dataform/issues/1546)) ([#15](googleapis/nodejs-dataform#15)) ([71f0add](googleapis/nodejs-dataform@71f0add))
* use google-gax v3.3.0 ([32373fd](googleapis/nodejs-dataform@32373fd))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Sep 13, 2023
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl pushed a commit that referenced this issue Sep 13, 2023
* Release v0.1.1

* chore: bump to v0.1.1
sofisl pushed a commit that referenced this issue Sep 26, 2023
🤖 I have created a release *beep* *boop*
---


## [0.2.0](googleapis/nodejs-bigquery-migration@v0.1.0...v0.2.0) (2022-09-14)


### Features

* Add MySQL dialect to bigquerymigration v2 client library ([b86b901](googleapis/nodejs-bigquery-migration@b86b901))


### Bug Fixes

* Allow passing gax instance to client constructor ([#12](googleapis/nodejs-bigquery-migration#12)) ([b86b901](googleapis/nodejs-bigquery-migration@b86b901))
* better support for fallback mode ([b86b901](googleapis/nodejs-bigquery-migration@b86b901))
* Change import long to require ([#13](googleapis/nodejs-bigquery-migration#13)) ([b9c6786](googleapis/nodejs-bigquery-migration@b9c6786))
* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-bigquery-migration/issues/1553)) ([#16](googleapis/nodejs-bigquery-migration#16)) ([c7ed184](googleapis/nodejs-bigquery-migration@c7ed184))
* Preserve default values in x-goog-request-params header ([#17](googleapis/nodejs-bigquery-migration#17)) ([64baf4b](googleapis/nodejs-bigquery-migration@64baf4b))
* Remove pip install statements ([#1546](https://github.com/googleapis/nodejs-bigquery-migration/issues/1546)) ([#15](googleapis/nodejs-bigquery-migration#15)) ([a7e4f6e](googleapis/nodejs-bigquery-migration@a7e4f6e))
* use google-gax v3.3.0 ([c7ed184](googleapis/nodejs-bigquery-migration@c7ed184))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants