Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% coverage? #215

Closed
ryanseys opened this issue Sep 17, 2014 · 1 comment
Closed

100% coverage? #215

ryanseys opened this issue Sep 17, 2014 · 1 comment
Assignees
@rakyll
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Milestone
Core Stable

Comments

@ryanseys
Copy link
Contributor

What's the goal for test coverage?
@rakyll
Copy link
Contributor

rakyll commented Sep 18, 2014

Test coverage goal cannot be measured by a numeric quantifier. You may have 100% test coverage but yet your code could be broken. Our goal is to cover as much as good tests for the sake of maintainability. So, when writing tests, think of what the future maintainer could do wrong and try to cover them as well as you are covering your existing feature set.

@rakyll rakyll closed this as completed Sep 18, 2014
@jgeewax jgeewax added this to the Core Stable milestone Feb 2, 2015
@snyk-bot snyk-bot mentioned this issue Jan 31, 2020
Open
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 7, 2020
@snyk-bot snyk-bot mentioned this issue Aug 16, 2020
Open
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@release-please @JustinBeckwith
chore: release 1.4.2 (#215)
4cd4800 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
@sofisl sofisl mentioned this issue Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 16, 2022
@JustinBeckwith
docs: document apiEndpoint over servicePath (#215)
8540f0b
sofisl pushed a commit that referenced this issue Oct 5, 2022
@JustinBeckwith
docs: document apiEndpoint over servicePath (#215)
9f70136
@sofisl sofisl mentioned this issue Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 5, 2022
@JustinBeckwith
docs: document apiEndpoint over servicePath (#215)
9b9de0b
@sofisl sofisl mentioned this issue Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Oct 8, 2022
@JustinBeckwith
docs: document apiEndpoint over servicePath (#215)
5b6420b
This was referenced Oct 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Oct 11, 2022
@JustinBeckwith @stephenplusplus
Release @google-cloud/language v2.0.2 (#215)
6930a9e 
This pull request was generated using releasetool.
sofisl pushed a commit that referenced this issue Oct 12, 2022
@renovate @JustinBeckwith
fix(deps): update dependency @google-cloud/common to v1 (#215)
9f55491
This was referenced Oct 12, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Oct 13, 2022
@bcoe
fix(build): update branch to main (#215)
813f9a4
sofisl pushed a commit that referenced this issue Oct 13, 2022
@release-please
chore: release 2.6.1 (#216)
53effa4 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.6.1](https://www.github.com/googleapis/nodejs-monitoring-dashboards/compare/v2.6.0...v2.6.1) (2021-09-08)


### Bug Fixes

* **build:** update branch to main ([#215](https://www.github.com/googleapis/nodejs-monitoring-dashboards/issues/215)) ([9506380](https://www.github.com/googleapis/nodejs-monitoring-dashboards/commit/950638076cec0320fa886e25b025844f58fce97e))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Oct 13, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 13, 2022
@gcf-owl-bot
fix: do not import the whole google-gax from proto JS (#1553) (#215)
516a281 
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
sofisl pushed a commit that referenced this issue Oct 13, 2022
@JustinBeckwith @sofisl
Release @google-cloud/language v2.0.2 (#215)
e4f4bf3 
This pull request was generated using releasetool.
sofisl pushed a commit that referenced this issue Nov 10, 2022
@jmdobry
Adds 6 quickstart examples (#218)
76ad3de 
* Add some simple "quickstart" samples.

* Add quickstart tests (#215)

* First draft of new tests

* Fix failing tests

* Fix comments

* Add comments.

* Update comments.

* Add another comment.

* Cleanup.

* Fix region tags.

* Fix comments.
sofisl pushed a commit that referenced this issue Nov 11, 2022
@bcoe
build(tests): fix coveralls and enable build cop (#215)
4d7617d
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 2.0.3 (#215)
9d3207d 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.0.3](https://www.github.com/googleapis/nodejs-web-risk/compare/v2.0.2...v2.0.3) (2020-11-25)


### Bug Fixes

* **browser:** check for fetch on window ([#214](https://www.github.com/googleapis/nodejs-web-risk/issues/214)) ([db8ef52](https://www.github.com/googleapis/nodejs-web-risk/commit/db8ef52b1cd557e2d334c718265d5abf47946f13))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
@yoshi-automation
build: --credential-file-override is no longer required (#215)
2355b33 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/4de22315-84b1-493d-8da2-dfa7688128f5/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@94421c4
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@renovate-bot
fix(deps): update dependency @google-cloud/pubsub to v2 (#215)
620b74d 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@google-cloud/pubsub](https://togithub.com/googleapis/nodejs-pubsub) | dependencies | major | [`^1.0.0` -> `^2.0.0`](https://renovatebot.com/diffs/npm/@google-cloud%2fpubsub/1.7.3/2.0.0) |

---

### Release Notes

<details>
<summary>googleapis/nodejs-pubsub</summary>

### [`v2.0.0`](https://togithub.com/googleapis/nodejs-pubsub/blob/master/CHANGELOG.md#&#8203;200-httpswwwgithubcomgoogleapisnodejs-pubsubcomparevv171v200-2020-05-20)

[Compare Source](https://togithub.com/googleapis/nodejs-pubsub/compare/v1.7.3...v2.0.0)

Please note that Node 8 is no longer supported, and Node 10 is the new minimum version of the runtime.

##### ⚠ BREAKING CHANGES

-   Please note that Node 8 is no longer supported, and Node 10 is the new minimum version of the runtime.
-   drop support for custom promises ([#&#8203;970](https://togithub.com/googleapis/nodejs-pubsub/issues/970))
-   convert to typescript ([#&#8203;923](https://togithub.com/googleapis/nodejs-pubsub/issues/923))
-   **deps:** update dependency [@&#8203;google-cloud/projectify](https://togithub.com/google-cloud/projectify) to v2 ([#&#8203;929](https://togithub.com/googleapis/nodejs-pubsub/issues/929))

##### Bug Fixes

-   **docs:** link to correct gaxOptions docs ([#&#8203;999](https://www.github.com/googleapis/nodejs-pubsub/issues/999)) ([312e318](https://www.github.com/googleapis/nodejs-pubsub/commit/312e318ceb36eafbeb487ede7e5dbf9ccd5dfb81))
-   regen protos and tests, formatting ([#&#8203;991](https://www.github.com/googleapis/nodejs-pubsub/issues/991)) ([e350b97](https://www.github.com/googleapis/nodejs-pubsub/commit/e350b97ad19e49e5fe52d5eeb1ad67c8bb6ddf33))
-   remove eslint, update gax, fix generated protos, run the generator ([#&#8203;955](https://www.github.com/googleapis/nodejs-pubsub/issues/955)) ([544a061](https://www.github.com/googleapis/nodejs-pubsub/commit/544a061b1b6d7fdc4051486c2b8ae5d14e1ec141))
-   remove unused dependencies ([#&#8203;998](https://www.github.com/googleapis/nodejs-pubsub/issues/998)) ([7b242a3](https://www.github.com/googleapis/nodejs-pubsub/commit/7b242a36212e0871b3918621fe9a5f51d1e6b733))
-   **close:** ensure in-flight messages are drained ([#&#8203;952](https://www.github.com/googleapis/nodejs-pubsub/issues/952)) ([93a2bd7](https://www.github.com/googleapis/nodejs-pubsub/commit/93a2bd726660b134fbd3e12335bfde29d13a2b78))
-   **deps:** update dependency [@&#8203;google-cloud/paginator](https://togithub.com/google-cloud/paginator) to v3 ([#&#8203;931](https://www.github.com/googleapis/nodejs-pubsub/issues/931)) ([b621854](https://www.github.com/googleapis/nodejs-pubsub/commit/b62185426b7f958ee41a1cff429bc5fb70635b4a))
-   **deps:** update dependency [@&#8203;google-cloud/precise-date](https://togithub.com/google-cloud/precise-date) to v2 ([#&#8203;934](https://www.github.com/googleapis/nodejs-pubsub/issues/934)) ([72b8d78](https://www.github.com/googleapis/nodejs-pubsub/commit/72b8d781ed3cbf9049101b9c2675f211fb3924ba))
-   **deps:** update dependency [@&#8203;google-cloud/projectify](https://togithub.com/google-cloud/projectify) to v2 ([#&#8203;929](https://www.github.com/googleapis/nodejs-pubsub/issues/929)) ([45d9880](https://www.github.com/googleapis/nodejs-pubsub/commit/45d988077d2db2fddbb4d22aac43c7f8a77e4dcc))
-   **deps:** update dependency [@&#8203;google-cloud/promisify](https://togithub.com/google-cloud/promisify) to v2 ([#&#8203;928](https://www.github.com/googleapis/nodejs-pubsub/issues/928)) ([3819877](https://www.github.com/googleapis/nodejs-pubsub/commit/3819877752d39cd042364bdd9ed01ff230aeed0b))
-   **deps:** update dependency google-auth-library to v6 ([#&#8203;935](https://www.github.com/googleapis/nodejs-pubsub/issues/935)) ([73fc887](https://www.github.com/googleapis/nodejs-pubsub/commit/73fc887c662b526690167286d2d5afda0cccad1b))

##### Build System

-   convert to typescript ([#&#8203;923](https://www.github.com/googleapis/nodejs-pubsub/issues/923)) ([2fc68ba](https://www.github.com/googleapis/nodejs-pubsub/commit/2fc68baff0cc2013468da7ef3dc8d547d4745989))

##### Miscellaneous Chores

-   drop support for custom promises ([#&#8203;970](https://www.github.com/googleapis/nodejs-pubsub/issues/970)) ([df462d3](https://www.github.com/googleapis/nodejs-pubsub/commit/df462d3dec4f733cb309eb6413aad382424e2125))

##### [1.7.1](https://www.github.com/googleapis/nodejs-pubsub/compare/v1.7.0...v1.7.1) (2020-04-06)

##### Bug Fixes

-   provide missing close() method in the generated gapic client ([#&#8203;941](https://www.github.com/googleapis/nodejs-pubsub/issues/941)) ([6bf8f14](https://www.github.com/googleapis/nodejs-pubsub/commit/6bf8f1481a1dea051c47697488e13b6facf20a26))

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-containeranalysis).
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#215)
f9a490d 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
fix: better support for fallback mode (#215)
1503ed0 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please @JustinBeckwith
chore: release 1.4.2 (#215)
2be968a 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 2.1.0 (#215)
f6ec489
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
docs(badges): tweak badge to use new preview/stable language (#1314) (#…
e599617 
…215)
sofisl pushed a commit that referenced this issue Nov 16, 2022
@yoshi-automation
build: only check --engine-strict for production deps (#215)
417500a 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a30f98da-7f8e-4a25-a598-8357af693448/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@5451633
@sofisl sofisl mentioned this issue Nov 16, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 17, 2022
@renovate @JustinBeckwith
fix(deps): update dependency @google-cloud/common to ^0.27.0 (#215)
c552817
@sofisl sofisl mentioned this issue Nov 17, 2022
Merged
4 tasks
@sofisl sofisl mentioned this issue Nov 30, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 30, 2022
@yoshi-automation
chore: clean up Node.js TOC for cloud-rad (#215)
f354fed 
* chore: clean up Node.js TOC for cloud-rad

Source-Author: F. Hinkelmann <[email protected]>
Source-Date: Wed Oct 21 09:26:04 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: f96d3b455fe27c3dc7bc37c3c9cd27b1c6d269c8
Source-Link: googleapis/synthtool@f96d3b4

* chore: fix Node.js TOC for cloud-rad

Source-Author: F. Hinkelmann <[email protected]>
Source-Date: Wed Oct 21 12:01:24 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 901ddd44e9ef7887ee681b9183bbdea99437fdcc
Source-Link: googleapis/synthtool@901ddd4
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@jkwlui
Release v0.10.0 (#215)
7ca433e
@sofisl sofisl mentioned this issue Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 13, 2023
@JustinBeckwith @alexander-fenster
docs: document apiEndpoint over servicePath (#215)
f98f2df
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Sep 14, 2023
@renovate @callmehiphop
fix(deps): update dependency yargs to v13 (#215)
9c8efbb
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakyll rakyll

Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
Core Stable
Development

No branches or pull requests
4 participants
@rakyll @jgeewax @ryanseys @yoshi-automation