-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a banner saying that we're *not* the same as the googleapis module on the gcloud landing doc? #556
Comments
Hmm, we already address this a bit in the README too by saying:
Hard to say what we should do here with changing the documentation on cloud.google.com because the docs there aren't even up to date for |
Just to add to this, in my case I'm new to Datastore (which btw is great!). I'm coming from SQL, Mongo, Postgres, DynamoDB and DocumentDB. The first stop for me was to Google "Datastore nodejs" and read up on the docs which all point to the googleapis. I only "stumbled" across the gcloud. I'm still not sure which came first, and why there is a gcloud? But, IMO it's much better and pretty nice to use. The big drawback is lack of documentation. For example, the Datastore docs don't mention anything about Datasets yet it's the first thing you come across once you get started with gcloud. I'm still confused about Keys as there's no documentation on what params to set for specifying ancestors, etc. |
@byrneciaran I totally agree. The documentation is poor and currently I'm looking at the nodejs gcloud source to figure out what's going on. It's not ideal. |
The docs can always be improved. We've been working hard to make a lot of improvements since this issue. @byrneciaran sorry for the delay in getting answers for these questions.
We actually have both of these addressed on our FAQ: https://googlecloudplatform.github.io/gcloud-node/#/faq
I'm not sure if you're talking about this library, but if you were to click on Datastore, you'd get to: https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.16.0/datastore. That page shows how to get a Datastore object and has a list of the methods, one being "dataset". Showing an example of how to use the From there or from the sidebar ("Dataset"), you can then get to https://googlecloudplatform.github.io/gcloud-node/#/docs/v0.16.0/datastore/dataset, which seems to cover the API pretty well. Is there something about our general site, hierarchy, or something else that simply makes things harder than they need to be?
This library's docs just represent our library. We link out to the official service docs for users to learn more about the basics of the services and how they work, best practices, etc. We don't want to duplicate all of the documentation (which is a lot!) that already exists there. @jonface can you be more specific about what is poor and needs fixing? @jgeewax RE: https://cloud.google.com/datastore/docs/concepts/entities#Datastore_Properties_and_value_types where they show examples like: var entity = {
key: { path: [{ kind: 'Employee', name: 'asalieri' }] }
// ... some properties ...
};
datastore.commit({
// Request insertion with complete key specified
mutation: { insert: [entity] },
mode: 'NON_TRANSACTIONAL'
}).execute(callback); I can see how this would be super confusing to a reader of those docs who we sent there from our docs for more information. Do we expect the cloud docs to ever show gcloud-node code? Assuming not or at least not for a while, is there a way to have the docs explain what library they're talking about for the example code? See below for a crude attempt at clarity: |
I don't think our library can do much more to clear this up, as explained in my last post. It would be great to see the official docs specify what library they're using when they show code examples. That's probably the single-most thing that can help. As stated above, if anyone else has suggestions for improvements, feel free to shout them out. For now, I think we've done all we can on our side. |
[PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343
🤖 I have created a release \*beep\* \*boop\* --- ### [3.3.3](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.2...v3.3.3) (2021-06-10) ### Bug Fixes * GoogleAdsError missing using generator version after 1.3.0 ([#556](https://www.github.com/googleapis/nodejs-video-intelligence/issues/556)) ([be3a053](https://www.github.com/googleapis/nodejs-video-intelligence/commit/be3a053818f7b59825f777460e129a10ada7fd79)) * remove doc config exception ([#553](https://www.github.com/googleapis/nodejs-video-intelligence/issues/553)) ([39d0f04](https://www.github.com/googleapis/nodejs-video-intelligence/commit/39d0f04a9f37e649dae5a2ad559d21db99665bdf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
[PR](googleapis/gapic-generator-typescript#878) within updated gapic-generator-typescript version 1.4.0 Committer: @summer-ji-eng PiperOrigin-RevId: 375759421 Source-Link: googleapis/googleapis@95fa72f Source-Link: googleapis/googleapis-gen@f40a343
🤖 I have created a release \*beep\* \*boop\* --- ### [3.3.3](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.2...v3.3.3) (2021-06-10) ### Bug Fixes * GoogleAdsError missing using generator version after 1.3.0 ([#556](https://www.github.com/googleapis/nodejs-video-intelligence/issues/556)) ([be3a053](https://www.github.com/googleapis/nodejs-video-intelligence/commit/be3a053818f7b59825f777460e129a10ada7fd79)) * remove doc config exception ([#553](https://www.github.com/googleapis/nodejs-video-intelligence/issues/553)) ([39d0f04](https://www.github.com/googleapis/nodejs-video-intelligence/commit/39d0f04a9f37e649dae5a2ad559d21db99665bdf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
replace `test` to `text` Source-Author: Summer Ji <[email protected]> Source-Date: Wed Jul 8 14:02:57 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 799d8e6522c1ef7cb55a70d9ea0b15e045c3d00b Source-Link: googleapis/synthtool@799d8e6 Co-authored-by: Justin Beckwith <[email protected]>
* docs: BinaryAuthorization.enabled field is marked as deprecated PiperOrigin-RevId: 464729666 Source-Link: googleapis/googleapis@c77c067 Source-Link: googleapis/googleapis-gen@68c2282 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjhjMjI4Mjg1MGFkZDE2ZGRhY2YzOTA2ZmYyZGFlODgwYmY5YjRjYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* samples: use modern samples layout * fix a bunch of problems * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* chore(deps): update dependency sinon to v15 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/compatibility-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/confidence-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-automl).
* docs: fix node release schedule link Co-authored-by: Jeffrey Rennie <[email protected]> Source-Link: googleapis/synthtool@1a24315 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:e08f9a3757808cdaf7a377e962308c65c4d7eff12db206d4fae702dd50d43430 * chore!: upgrade to Node 14 * run lint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Sofia Leon <[email protected]>
In #553, @byrneciaran mentioned that there was some confusion between
gcloud
andgoogleapis
modules for talking to Datastore specifically. I think that might be a bigger issue of distinguishing for any of the cloud services.Seeing as we can't change cloud.google.com yet to use
gcloud
for the examples, could we at least make a note somewhere in our docs saying that we're different, and you should stick with our docs for the most part?Or is that overreaching?
The text was updated successfully, but these errors were encountered: