-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README should say "Authentication", not "Authorization" #841
Comments
Your logic seems sound to me! I wish there was a trick for that, the closest thing I know of is linking to sections, e.g. https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/README.md#authorization |
I went to create a PR this morning when filing this issue when I realized I don't have a fork. @callmehiphop shall I create one? |
@dhermes If you don't mind, that would be awesome! |
4 tasks
sofisl
pushed a commit
that referenced
this issue
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [4.1.2](https://www.github.com/googleapis/nodejs-dialogflow/compare/v4.1.1...v4.1.2) (2021-07-12) ### Bug Fixes * **deps:** google-gax v2.17.1 ([#840](https://www.github.com/googleapis/nodejs-dialogflow/issues/840)) ([0035d9c](https://www.github.com/googleapis/nodejs-dialogflow/commit/0035d9cfd77045332446472e97cc06d48ca39beb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm kind of on the fence if I even believe this to be true or not.
The OAuth 2.0 flows themselves are authorization (i.e. authorizing the clients to act on behalf of the user) but the service account flows are user-independent and really serve to authenticate an entity with a given access.
Also, when we use non-service accounts we just use the Application Default Credentials from the
gcloud
CLI. These will already have a refresh token, so again we perform / participate in no authorization, just authentication.PS Sorry for the esoteric issue, but I was adding this section to the
gcloud-python
README and it just occurred to me.PPS Is there some magic trick to get a link to lines in a MD file on GitHub?
The text was updated successfully, but these errors were encountered: