Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add support for generation on getSignedUrl #1058

Merged
merged 1 commit into from
Jan 14, 2016

Conversation

simonfan
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 12, 2016
@simonfan
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 12, 2016
@callmehiphop callmehiphop added api: storage Issues related to the Cloud Storage API. enhancement labels Jan 12, 2016
@@ -1173,6 +1173,8 @@ File.prototype.getSignedUrl = function(options, callback) {
}[options.action];

var name = encodeURIComponent(this.name);
var targetGeneration = is.undefined(this.generation) ?
false : encodeURIComponent(this.generation);

This comment was marked as spam.

This comment was marked as spam.

@callmehiphop
Copy link
Contributor

Thanks for the pull request, @simonfan! I had a small nitpick on the code and it also appears that the lint task is failing (you can lint the code by running npm run lint), if you could address these items I would be happy to merge this change in! :)

@simonfan
Copy link
Contributor Author

@callmehiphop great! I'll have a look on it later today and I'll let you know ;)

@simonfan
Copy link
Contributor Author

There seems to be some issue with the .travis.yml before install hook

The error at the travis build was:

0.00s$ export CXX=g++-4.8
0.00s$ $CXX --version
/home/travis/build.sh: line 45: g++-4.8: command not found
The command "$CXX --version" failed and exited with 127 during .

@stephenplusplus
Copy link
Contributor

Hey @simonfan, thanks for this PR! I restarted the test, and that error seems to have disappeared. Travis looks happy now, so back to you, @callmehiphop!

@callmehiphop
Copy link
Contributor

@simonfan looks great! Would you mind squashing your commits?

callmehiphop added a commit that referenced this pull request Jan 14, 2016
storage: add support for generation on getSignedUrl
@callmehiphop callmehiphop merged commit a226a64 into googleapis:master Jan 14, 2016
@callmehiphop
Copy link
Contributor

Thanks @simonfan!

💃

@simonfan
Copy link
Contributor Author

;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants