Update README.md #1258
Closed
Update README.md #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `{ reuseExisting: true }` to `subscribe` method call in pubsub sample
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot
added
the
cla: no
|
I signed it! |
|
CLAs look good, thanks! |
googlebot
added
cla: yes
| @@ -243,7 +243,7 @@ topic.publish({ | |||
| }, function(err) {}); | |||
|
|
|||
| // Subscribe to the topic. | |||
| topic.subscribe('new-subscription', function(err, subscription) { | |||
| topic.subscribe('new-subscription', { reuseExisting: true }, function(err, subscription) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
why the option /node_modules/protobufjs/dist/protobuf.js:2490
throw Error(this+"#"+keyOrObj+" is not a field: undefined");
^
Error: .google.pubsub.v1.Subscription#reuseExisting is not a field: undefined
at Error (native)
at MessagePrototype.set (/node_modules/protobufjs/dist/protobuf.js:2490:35)
at MessagePrototype.set (/node_modules/protobufjs/dist/protobuf.js:2483:38)
at Message (/node_modules/protobufjs/dist/protobuf.js:2411:34)
at serialize (/node_modules/grpc/src/node/src/common.js:87:23)
at Client.makeUnaryRequest [as createSubscription] (/node_modules/grpc/src/node/src/client.js:395:19)
at Object.request (/node_modules/@google-cloud/common-grpc/src/service.js:265:32)
at makeRequest (/node_modules/retry-request/index.js:88:28)
at retryRequest (/node_modules/retry-request/index.js:58:3)
at PubSub.GrpcService.request (/node_modules/@google-cloud/common-grpc/src/service.js:283:3)
real 0m1.316s
user 0m0.952s
sys 0m0.092s |
|
This option was removed in favor of always re-using an existing subscription: #1799 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(re: #1257)
Added
{ reuseExisting: true }tosubscribemethod call in pubsub sample