Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling usage with access token only #1410

Closed

Conversation

juliusse
Copy link

@juliusse juliusse commented Jul 5, 2016

Fixes #1346
This pull request enables gloud-node users to only specify an access_token for authentication.
As @stephenplusplus suggested, the solution just not uses the auto-auth client, but creates a simple one that just sets the access_token.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 5, 2016
@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 0eaa80a on juliusse:enabled-auth-with-access-token into 24810b9 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor

stephenplusplus commented Jul 6, 2016

Thanks for this :) There are a couple edge cases, though:

  1. Calls made with gRPC APIs won't use the token (Datastore, Logging, Pub/Sub for now)
  2. There are other libraries we use-- gce-images & gcs-resumable-upload-- that would need to be updated to accept just an access token (and we would have to provide the access token the user give us to those libraries)

@murgatroid99 is there a way to provide gRPC with just an access token?

@stephenplusplus
Copy link
Contributor

I'm going to close the PR (thank you, though!) and let the discussion carry on in #1346. As mentioned above, it's rather tricky to implement.

@sedouard
Copy link

sedouard commented Feb 8, 2017

Now that gRPC can easily set metadata (and therefore the access_token) is it in the plan to add access_token to the RESTful interfaces?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants